/_synapse/admin/v2/users is broken

[aaronraimist]

Running the /_synapse/admin/v2/users as documented produces an internal server error

Postgres logs:

STATEMENT:  SELECT name, password_hash, is_guest, admin, user_type, deactivated FROM users WHERE is_guest = false AND deactivated = false ORDER BY name ASC LIMIT 10 OFFSET 0
ERROR:  operator does not exist: smallint = boolean at character 95

\d users shows that is_guest and deactivated are type smallint not boolean.

                          Table "public.users"
           Column           |   Type   | Collation | Nullable | Default
----------------------------+----------+-----------+----------+---------
 name                       | text     |           |          |
 password_hash              | text     |           |          |
 creation_ts                | bigint   |           |          |
 admin                      | smallint |           | not null | 0
 upgrade_ts                 | bigint   |           |          |
 is_guest                   | smallint |           | not null | 0
 appservice_id              | text     |           |          |
 consent_version            | text     |           |          |
 consent_server_notice_sent | text     |           |          |
 user_type                  | text     |           |          |
 deactivated                | smallint |           | not null | 0

[richvdh]

@awesome-manuel any chance you could take a look at this?

[awesome-manuel]

@richvdh Sure, I can fix it.

[wellic]

@awesome-manuel

I think you forgot to change in code: parse_boolean to parse_integer for guests and deactivated:

1. guests = parse_integer(request, "guests", default=1)
2. deactivated = parse_integer(request, "deactivated", default=0)