Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Make the 'and also log out all my devices' behaviour of password reset optional. #6976

Closed
lampholder opened this issue Feb 24, 2020 · 6 comments
Assignees

Comments

@lampholder
Copy link
Member

lampholder commented Feb 24, 2020

Password reset signs out all of your sessions.

The 'password reset' and 'log out all devices' actions do not need to be inseparable. If you suspect your account has been compromised then logging out your other devices is important. In (I think) all other cases it is overkill.

Can we make a backwards-compatible change to the password reset API by adding an optional "and log out all my devices" parameter which defaults to 'true'?

@richvdh
Copy link
Member

richvdh commented Feb 24, 2020

Related to #6963, though that seems to be about regular password changes rather than password resets.

@clokep
Copy link
Member

clokep commented Mar 4, 2020

As far as I can tell this is a duplicate of #6963 since the code paths converge into the same password reset flow (i.e you eventually end up at /_matrix/client/r0/account/password).

Regardless I'll look into this.

@clokep clokep self-assigned this Mar 4, 2020
@richvdh
Copy link
Member

richvdh commented Mar 5, 2020

@neilisfragile to discuss the UX implications of this with @lampholder

@neilisfragile
Copy link
Contributor

After irl, we want the option to specify via the API but default to the current behaviour. So exactly as @lampholder describes above.

The idea being that the client can support ' I've been hacked, delete all devices!!!' flow along side a 'oh I just want to update my password' flow.

@richvdh
Copy link
Member

richvdh commented Mar 16, 2020

After irl, we want the option to specify via the API but default to the current behaviour.

the spec changes needed for this are at matrix-org/matrix-spec-proposals#2457.

@clokep
Copy link
Member

clokep commented Mar 18, 2020

Done in #7085.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants