Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Parameters in <tests/rest/client/v1/test_events.py> in wrong order #7242

Closed
Zay11Zay opened this issue Apr 7, 2020 · 3 comments
Closed

Parameters in <tests/rest/client/v1/test_events.py> in wrong order #7242

Zay11Zay opened this issue Apr 7, 2020 · 3 comments

Comments

@Zay11Zay
Copy link
Contributor

Zay11Zay commented Apr 7, 2020

Description

In the prepare() method in <tests/rest/client/v1/test_events.py>, the parameters are in the wrong order.
Currently: def prepare(self, hs, reactor, clock):
Should be: def prepare(self, reactor, clock, hs)

Steps to reproduce

  • list the steps
  • that reproduce the bug
  • using hyphens as bullet points

Version information

  • Homeserver:

If not matrix.org:

  • Version:

  • Install method:

  • Platform:
@clokep
Copy link
Member

clokep commented Apr 7, 2020

Thanks for filing this issue, any chance you can put up a pull request with this change?

@Zay11Zay
Copy link
Contributor Author

Zay11Zay commented Apr 7, 2020

Sure, just submitted

@clokep
Copy link
Member

clokep commented Apr 14, 2020

Fixed by #7243.

@clokep clokep closed this as completed Apr 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants