Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

implement MSC2174: Move the redacts key to a sane place #7486

Closed
richvdh opened this issue May 13, 2020 · 7 comments · Fixed by #15395
Closed

implement MSC2174: Move the redacts key to a sane place #7486

richvdh opened this issue May 13, 2020 · 7 comments · Fixed by #15395
Assignees
@clokep
Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-p2 (Deprecated Label) Z-Unimplemented-MSCs MSCs which we would like to implement, but haven't

Comments

@richvdh
Copy link
Member

richvdh commented May 13, 2020

It would sure be nice to implement MSC2174 - maybe even in time to get it into room v6.
@tulir
Copy link
Member

tulir commented May 14, 2020

It would be very not nice to have to migrate redaction event format twice

@anoadragon453
Copy link
Member

anoadragon453 commented May 14, 2020 •
edited
Loading

This is now slated for room v7+.

@anoadragon453 anoadragon453 added the z-p2 (Deprecated Label) label May 14, 2020
@richvdh
Copy link
Member Author

richvdh commented May 15, 2020

It would be very not nice to have to migrate redaction event format twice

I'm not quite sure what you mean by this. If you're against the principle of MSC2174, then those comments belong on the MSC.

@tulir
Copy link
Member

tulir commented May 15, 2020

This step should be skipped and we should go straight for mass redactions.

@richvdh
Copy link
Member Author

richvdh commented May 15, 2020

ah right. yes, maybe. Mass redactions are MSC2244, ftr.

@callahad callahad added the Z-Unimplemented-MSCs MSCs which we would like to implement, but haven't label Jun 10, 2021
@erikjohnston erikjohnston added the T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. label Jul 26, 2021
@turt2live
Copy link
Member

Required for https://github.com/matrix-org/matrix-doc/issues/3097

@clokep
Copy link
Member

clokep commented Dec 29, 2021

Note that #8984 is somewhat related to this as MSC2176 updates the redaction rules based on MSC2174. There's some confusing overlap there.

@turt2live turt2live self-assigned this May 4, 2022
@clokep clokep assigned clokep and unassigned turt2live Apr 5, 2023
@clokep clokep mentioned this issue Apr 5, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
T-Enhancement New features, changes in functionality, improvements in performance, or user-facing enhancements. z-p2 (Deprecated Label) Z-Unimplemented-MSCs MSCs which we would like to implement, but haven't
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement MSC2174: move redacts to a content property. matrix-org/synapse
7 participants
@callahad @clokep @turt2live @anoadragon453 @richvdh @tulir @erikjohnston