Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Concurrent event linearizer doesn't work when using event creator. #7792

Closed
erikjohnston opened this issue Jul 6, 2020 · 5 comments
Closed
Assignees
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)

Comments

@erikjohnston
Copy link
Member

We have a linearizer that (tries) to stop more than 5 events being created and persisted concurrently for a given room. This is to prevent the failure mode where if events are written at a greater rate than they can be persisted the forward extremities count balloons, resulting in further degradation in performance.

When running with event creators the limit is enforced on the individual event creators. However, the persist event replication request to the event writer process can time out, resulting in the event creator thinking that the event is no longer being processed even though it still is being processed by the writer.

We can't simply move the linearizer to the event writer process as it needs to be applied before we select the prev events.

@richvdh
Copy link
Member

richvdh commented Jul 6, 2020

is this the same as #7086?

@erikjohnston
Copy link
Member Author

Oh, maybe. We do do this correctly for non-worker mode

@richvdh
Copy link
Member

richvdh commented Jul 6, 2020

also related: #7682

@richvdh
Copy link
Member

richvdh commented Sep 29, 2020

Hopefully fixed by #8400? leaving open for now pending confirmation

@erikjohnston
Copy link
Member Author

Yes, I'm hoping it'll fix it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
z-bug (Deprecated Label) z-p2 (Deprecated Label)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants