Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Option to hide bridge users from user directory #8969

Closed
waclaw66 opened this issue Dec 17, 2020 · 3 comments
Closed

Option to hide bridge users from user directory #8969

waclaw66 opened this issue Dec 17, 2020 · 3 comments
Labels
A-Application-Service Related to AS support A-User-Directory z-feature (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)

Comments

@waclaw66
Copy link

waclaw66 commented Dec 17, 2020

Hello together.

I would like to ask for a new feature.
I use mautrix-facebook bridge and I would like to prevent from searching puppets of that bridge.
My synapse is currently configured like:

user_directory:
  enabled: true
  search_all_users: true

A possibility to filter them by appservice_id from users table would be helpful or just simply expose native users only.

Thanks for considering it.

Regards.

@erikjohnston erikjohnston added z-feature (Deprecated Label) z-p3 (Deprecated Label) labels Jan 8, 2021
@erikjohnston erikjohnston changed the title User search filter Option to hide bridge users from user directory Jan 8, 2021
@erikjohnston
Copy link
Member

This seems reasonable, I don't think the core team will have time to add it anytime soon but we'd be happy to accept a PR that does this.

@erikjohnston erikjohnston added the Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution label Jan 8, 2021
@waclaw66
Copy link
Author

Soved by #10789

@DMRobertson
Copy link
Contributor

Soved by #10789

I think the change responsible is actually f7b034a in #10960.

Note that this doesn't introduce the option to configure whether bridge users are omitted or included in the directory. At present they're always omitted. I think the team was broadly amenable to the idea of allowing appservices to configure whether their users were exposed in the directory, but we don't have the time to work on that at present.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Application-Service Related to AS support A-User-Directory z-feature (Deprecated Label) Z-Help-Wanted We know exactly how to fix this issue, and would be grateful for any contribution z-p3 (Deprecated Label)
Projects
None yet
Development

No branches or pull requests

4 participants