Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

mypy failing on Twisted 21.2.0 #9513

Closed
clokep opened this issue Mar 1, 2021 · 4 comments · Fixed by #9678
Closed

mypy failing on Twisted 21.2.0 #9513

clokep opened this issue Mar 1, 2021 · 4 comments · Fixed by #9678
Assignees
@clokep
Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@clokep
Copy link
Member

clokep commented Mar 1, 2021

The mypy check is failing on 21.2.0, which adds significantly more type hints internal to Twisted.

There's currently 196 errors, but hopefully it isn't too bad to clean them up!
@clokep clokep added the T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. label Mar 1, 2021
@clokep clokep self-assigned this Mar 1, 2021
This was referenced Mar 1, 2021
Merged
Merged
Merged
Merged
Merged
@clokep clokep mentioned this issue Mar 8, 2021
Merged
@clokep
Copy link
Member Author

clokep commented Mar 10, 2021

Filed Shoobx/mypy-zope#34 about an issue I'm having...

@clokep clokep mentioned this issue Mar 11, 2021
Merged
@clokep
Copy link
Member Author

clokep commented Mar 12, 2021

Filed Shoobx/mypy-zope#34 about an issue I'm having...

It seems that mypy-zope has an issue with using the mypy cache, not sure if there will be a solution, but for now runnig rm -r .mypy_cache removes some spurious errors.

This was referenced Mar 12, 2021
Merged
Merged
@clokep
Copy link
Member Author

clokep commented Mar 15, 2021

This is all "fixed" now, minus the issue with the mypy cache. I'm not sure what to do about this. We can:

  • Leave it and ignore the issue.
  • Add a rm .mypy_cache to the lint.sh script.

I don't have other ideas. 😄

@clokep clokep mentioned this issue Mar 15, 2021
Merged
@callahad
Copy link
Contributor

Decision:

  1. Apply the rm hack to lint.sh as a stopgap
  2. (Briefly) look into upstream code to scope how difficult it would be to supply a patch

This was referenced Mar 18, 2021
Merged
Closed
Merged
@clokep clokep linked a pull request Mar 24, 2021 that will close this issue
Bump mypy-zope to 0.2.13. #9678
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@clokep clokep

Labels
T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bump mypy-zope to 0.2.13. matrix-org/synapse
2 participants
@callahad @clokep