/thirdparty/protocols API returned an empty object for an appservice that wasn't ready

[jaller94]

Description

/thirdparty/protocols returned

{ irc: {} }

The irc object is missing a few required values.

https://matrix.org/docs/spec/client_server/r0.6.1#get-matrix-client-r0-thirdparty-protocols

Steps to reproduce

• I set up my IRC bridge but the pingback port wasn't working yet (I had set it to the wrong port in the appservice file) and the IRC server on localhost wasn't connecting yet.

Synapse-config, Bridge config and logs (look around the time 2021-03-25 20:44):
https://gateway.pinata.cloud/ipfs/QmTbjP9PwfaTELkYQQ1HmznR4n8GNusveE6BwpZXw5tjk4

Version information

• Version:

• Synapse 1.29.0 with Python 3.8.8

• https://registry.hub.docker.com/layers/matrixdotorg/synapse/latest/images/sha256-67a507a29e0406a0e93a9040617380f7310f625e86adb5652ef24cd1ce39db48

• Install method:

• DockerHub's matrixdotorg/synapse:latest

• Platform:

• Manjaro Linux (based on the repo of Arch Linux)

Additional notes:

The API response caused an issue in Element Web because it's not spec-compliant.

element-hq/element-web#16789

Peek.2021-03-25.20-45.mp4

[cremesk]

@jaller94 You can delete the protocols section of the registration file, if you are running your own irc bridge.
after this you need to restart synapse.

This fixed the Bug Temporary and disabled the "IRC-Network"-Menu.

eg.: "TildeChat"

brief explanation of how i came up with this:

i got is problem after i enables the "dynamic channels" feature in appservice-irc-bridge.
the bridge add an area to the local room explorer which contains the irc-rooms.

the room-explorer is not longer working locally but it works from other instances..

my server is returning an invalid API response to /protocols - instances is marked as required but my is returning undefined.
see: https://matrix.envs.net/_matrix/media/r0/download/envs.net/3d67c2324bf239a8e38ba3b02ebfe04ee908ff79

[Half-Shot]

The bug here is that synapse shouldn't return results for bridges it can't reach on this endpoint, rather than a bug in the bridges themselves.

[skepticalwaves]

Looks like https://github.com/Half-Shot/matrix-appservice-discord currently returns an empty protocol as well