Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Add missing type hints to config base classes #11377

Merged
merged 11 commits into from
Nov 23, 2021
Merged

Add missing type hints to config base classes #11377

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
7b2f0cd
Consolidate _base.py and _base.pyi types.
clokep Nov 17, 2021
7326696
Match _base.pyi to HomeServerConfig.
clokep Nov 17, 2021
c71872a
Fix-up type hints that parse_duration is an int.
clokep Nov 17, 2021
91416e1
Fix incorrect attribute references.
clokep Nov 17, 2021
9596d16
Ensure configurations exist in tests.
clokep Nov 17, 2021
75bf56c
Add type hints to generate_files.
clokep Nov 17, 2021
1b7cd15
str -> bytes for PEMs.
clokep Nov 17, 2021
f918c13
Newsfragment
clokep Nov 17, 2021
e123eca
Merge remote-tracking branch 'origin/develop' into clokep/config-types
clokep Nov 18, 2021
7654481
Newsfragment
clokep Nov 18, 2021
e6c99a0
Merge remote-tracking branch 'origin/develop' into clokep/config-types
clokep Nov 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/11377.bugfix
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix a bug introduced in v1.45.0 where the `read_templates` method of the module API would error.
1 change: 1 addition & 0 deletions changelog.d/11377.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add type hints to configuration classes.
3 changes: 3 additions & 0 deletions mypy.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,9 @@ disallow_untyped_defs = True
[mypy-synapse.app.*]
disallow_untyped_defs = True

[mypy-synapse.config._base]
disallow_untyped_defs = True

[mypy-synapse.crypto.*]
disallow_untyped_defs = True

Expand Down
Loading