From e0858679608f9ddd1826d68fa4b15f9a0516fc87 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Wed, 23 Feb 2022 13:53:22 +0000 Subject: [PATCH 1/2] Add logging to `/sync` for debugging #11916 --- synapse/handlers/sync.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/synapse/handlers/sync.py b/synapse/handlers/sync.py index 98eaad33184e..0aa3052fd6ac 100644 --- a/synapse/handlers/sync.py +++ b/synapse/handlers/sync.py @@ -697,6 +697,15 @@ async def get_state_at( else: # no events in this room - so presumably no state state = {} + + # (erikj) This should be rarely hit, but we've had some reports that + # we get more state down gappy syncs than we should, so let's add + # some logging. + logger.info( + "Failed to find any events in room %s at %s", + room_id, + stream_position.room_key, + ) return state async def compute_summary( From 75e21d9a5387eb9aa49ca47131e6957293bbc894 Mon Sep 17 00:00:00 2001 From: Erik Johnston Date: Wed, 23 Feb 2022 13:54:34 +0000 Subject: [PATCH 2/2] Newsfile --- changelog.d/12068.misc | 1 + 1 file changed, 1 insertion(+) create mode 100644 changelog.d/12068.misc diff --git a/changelog.d/12068.misc b/changelog.d/12068.misc new file mode 100644 index 000000000000..72b211e4f55f --- /dev/null +++ b/changelog.d/12068.misc @@ -0,0 +1 @@ +Add some logging to `/sync` to try and track down #11916.