This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Factor out some common Complement CI setup commands to a script. #13157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
reivilibre
force-pushed
the
rei/complement_run_dedupe
branch
2 times, most recently
from
f04a25b
to
b23308f
Compare
reivilibre
force-pushed
the
rei/complement_run_dedupe
branch
from
b23308f
to
f61931f
Compare
squahtx
approved these changes
Jul 5, 2022
Comment on lines
+9
to
+10
| alias block='{ set +x; } 2>/dev/null; func() { echo "::group::$*"; set -x; }; func' | ||
| alias endblock='{ set +x; } 2>/dev/null; func() { echo "::endgroup::"; set -x; }; func' |
There was a problem hiding this comment.
Out of curiosity, what happens if we don't set +x here?
There was a problem hiding this comment.
It leads to extra noise being printed (set +xing here is the entire point of this awkward alias — I don't want to see 'echo "::group::$*"' in the trace output etc)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seemed like the least bad way to do it.
A little bit of trickery is included to cleanly create log groups for the setup portions, without also tracing (due to
-x) theechostatements for these.