This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Support thread IDs on receipts (implement MSC3771) #13202
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clokep
force-pushed
the
clokep/thread-read-receipts
branch
from
b2d9b72 to
9f0c43a
Compare
|
I think this needs to pull in #13181 to mark specific threads as read. |
clokep
force-pushed
the
clokep/thread-read-receipts
branch
2 times, most recently
from
c87ebec to
2b922b0
Compare
clokep
force-pushed
the
clokep/thread-read-receipts
branch
from
2b922b0 to
c96aedb
Compare
clokep
force-pushed
the
clokep/thread-notifs
branch
from
50a1187 to
b091d58
Compare
clokep
force-pushed
the
clokep/thread-read-receipts
branch
4 times, most recently
from
0faf7dd to
5a0feda
Compare
clokep
commented
Aug 1, 2022
Comment on lines
-290
to
-379
| # XXX All threads should have the same stream ordering? | ||
| max_summary_stream_ordering = max( | ||
| summary_stream_ordering, max_summary_stream_ordering | ||
| ) |
There was a problem hiding this comment.
Something seems a little off in this code -- should each thread have it's own summary stream ordering or each room? The code needs to be audited either way to ensure that we're doing the proper thing here.
clokep
force-pushed
the
clokep/thread-notifs
branch
from
b091d58 to
a6d67c2
Compare
clokep
force-pushed
the
clokep/thread-read-receipts
branch
2 times, most recently
from
3996cde to
69c4fe4
Compare
clokep
force-pushed
the
clokep/thread-notifs
branch
from
a6d67c2 to
9b92fce
Compare
clokep
force-pushed
the
clokep/thread-read-receipts
branch
2 times, most recently
from
408f069 to
fa237ad
Compare
clokep
force-pushed
the
clokep/thread-notifs
branch
3 times, most recently
from
7d3e937 to
d56296a
Compare
clokep
force-pushed
the
clokep/thread-read-receipts
branch
2 times, most recently
from
f0ab6a7 to
cd23807
Compare
clokep
force-pushed
the
clokep/thread-read-receipts
branch
from
cd23807 to
72d567d
Compare
clokep
force-pushed
the
clokep/thread-read-receipts
branch
from
72d567d to
185b038
Compare
This was referenced Sep 6, 2022
|
Based on feedback in #13181, some of this is going to be reworked; I'm going to close this for now. |
|
See #13782 for a replacement PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track thread IDs for receipts, implementing MSC3771.
Depends on #13198, #13181.
Part of #12550.
TODO
/versionsparameter.