This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
Fix LruCache. Make TreeCache track its own size. #538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikjohnston
changed the title
|
Hmm, there are a couple of odd things actually |
| @@ -142,10 +140,11 @@ def cache_clear(): | |||
| list_root[NEXT] = list_root | |||
| list_root[PREV] = list_root | |||
| cache.clear() | |||
| self.size = 0 | |||
There was a problem hiding this comment.
Why is this still here?
There was a problem hiding this comment.
Also why didn't this fix the problem OOI?
There was a problem hiding this comment.
I dislike the LruCache trying to keep track of the size of the underlying cache. I much prefer that caches/collections keep track of their own size.
|
Also could you add a test to check you've fixed the bug? |
|
@NegativeMjark PTAL |
|
LGTM |
erikjohnston
added a commit
that referenced
this pull request
Jan 29, 2016
Fix LruCache. Make TreeCache track its own size.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LruCachefailed to resetself.sizewhenclearwas called. This meant thatself.sizecould be much large than the actual size, thereby reducing the actual effective size of the cache.This PR fixes the issue by reverting the
LruCacheto not track size and instead uselen(..)on the underlying cache.TreeCachenow keeps track of its own size.