Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around Synapse Docker build failures by using a --cache-dir #1271

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

squahtx
Copy link
Contributor

@squahtx squahtx commented Jul 19, 2022

When the --no-cache-dir option is given to pip, setuptools>=48.0.0
installs msgpack to /usr/lib/python3.7/site-packages/ instead of
/usr/local/lib/python3.7/dist-packages/, where Python can't find it.


Fixes #1269.

When the `--no-cache-dir` option is given to pip, setuptools>=48.0.0
installs msgpack to `/usr/lib/python3.7/site-packages/` instead of
`/usr/local/lib/python3.7/dist-packages/`, where Python can't find it.
@squahtx squahtx requested a review from a team as a code owner July 19, 2022 14:37
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for digging into this. It looks like a Herculean effort to me!

Should we be using poetry 1.1.14 here, as in matrix-org/synapse#13285? Perhaps not---I don't think we're generating lockfiles, just reading from them?

No objections otherwise.

@squahtx
Copy link
Contributor Author

squahtx commented Jul 19, 2022

To be honest I still have no idea why only msgpack is affected or how the --no-cache-dir option breaks things, only that it does. This fix is very much a workaround.

Should we be using poetry 1.1.14 here, as in matrix-org/synapse#13285? Perhaps not---I don't think we're generating lockfiles, just reading from them?

I suppose we ought to use poetry 1.14, if that's what Synapse recommends. Though that's orthogonal to the build failures and merits another PR. Not that it should make a difference, since we're just reading lockfiles as you say.

Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! SGTM. I assume the dendrite failures are a flake or known problem; they can't be caused by this.

@squahtx
Copy link
Contributor Author

squahtx commented Jul 19, 2022

Agreed, let's merge it.

@squahtx squahtx merged commit a975f2a into develop Jul 19, 2022
@squahtx squahtx deleted the squah/fix_synapse_docker_build branch July 19, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexplained sytest poetry build failure weirdness
2 participants