This repository has been archived by the owner on Mar 19, 2022. It is now read-only.
NodeConfigCommand should create node_path directory when generating json file
#253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mat, wanna review? |
|
Looks decent. Kind of embarrassed it didn't do this already. Does the memoization of @node_config buy us anything? I'm partial to leave On Monday, May 27, 2013, Teemu Matilainen wrote:
-Mat about.me/matschaffer |
|
Nah, I was just feeling pity for all the Pathname instances created for |
tmatilai
added a commit
that referenced
this pull request
May 28, 2013
NodeConfigCommand should create `node_path` directory when generating json file
tmatilai
added a commit
that referenced
this pull request
Jun 14, 2013
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.