Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport system name memoization #142

Open
LastTalon opened this issue Nov 18, 2024 · 1 comment
Open

Backport system name memoization #142

LastTalon opened this issue Nov 18, 2024 · 1 comment
Labels
improvement An imperfection we can make better

Comments

@LastTalon
Copy link
Member

Current behavior

Currently in v0.8 system names rely on debug.info which is a somewhat costly operation.

Proposed improvement

Backport #134 to our LTS v0.8 branch in order to support this for users who are not yet ready to update to v0.9.
@LastTalon LastTalon added the improvement An imperfection we can make better label Nov 18, 2024
@LastTalon LastTalon added this to the Initial v0.8 LTS milestone Nov 18, 2024
@LastTalon LastTalon removed this from the Initial v0.8 LTS milestone Dec 7, 2024
@jackTabsCode
Copy link
Contributor

Re conversation in Discord: I ran into an error when hot-reloading a system after I made these changes. I'm not able to reproduce it, but due to it being such a small performance improvement anyway, I don't think it's worth backporting if potentially unstable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
improvement An imperfection we can make better
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LastTalon @jackTabsCode