Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hardhat quickstart new templates #312

Merged
merged 4 commits into from
Feb 10, 2025
Merged

fix: hardhat quickstart new templates #312

merged 4 commits into from
Feb 10, 2025

Conversation

uF4No
Copy link
Contributor

@uF4No uF4No commented Jan 27, 2025

Description

Updates the Hardhat quickstart guide to use updated templates in zksync-cli. (from matter-labs/zksync-contract-templates#26)

Linked Issues

matter-labs/zksync-contract-templates#26

Additional context

@uF4No uF4No requested a review from a team as a code owner January 27, 2025 10:39
Copy link

github-actions bot commented Jan 27, 2025

Visit the preview URL for this PR (updated for commit e1ee365):

https://zksync-docs-staging-5eb09--pr312-fix-hh-quickstart-70xqkz1q.web.app

(expires Mon, 17 Feb 2025 11:04:21 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11

@uF4No uF4No changed the title Fix: Hardhat quickstart new CLI templates fix: hardhat quickstart new templates Jan 27, 2025
Copy link
Member

@popzxc popzxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but I didn't test it myself -- probably worth asking someone to try the new guide and make sure that everything works.

@uF4No uF4No merged commit 233192e into main Feb 10, 2025
9 checks passed
@uF4No uF4No deleted the fix/hh-quickstart branch February 10, 2025 15:49
Copy link

🎉 This PR is included in version 1.55.6 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

MexicanAce pushed a commit that referenced this pull request Feb 10, 2025
# Description

Fix issue with build introduced in #312 

## Linked Issues


## Additional context
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants