Skip to content

Commit

Permalink
Update Share Button (#2432)
Browse files Browse the repository at this point in the history
* update shareboard button to always display

* lint fixes

* fix/update unit tests

* update shareboard button to always display

* lint fixes

* fix/update unit tests

* Updating UI for share dialog

* Updating test

* update tests

* update to include view

Co-authored-by: Asaad Mahmood <asaadmahmood@users.noreply.github.com>
  • Loading branch information
sbishel and asaadmahmood authored Mar 2, 2022
1 parent 8ccf772 commit 50020ce
Show file tree
Hide file tree
Showing 10 changed files with 418 additions and 198 deletions.
18 changes: 17 additions & 1 deletion webapp/src/components/__snapshots__/centerPanel.test.tsx.snap
Original file line number Diff line number Diff line change
Expand Up @@ -8377,7 +8377,23 @@ exports[`components/centerPanel should match snapshot for Kanban, not shared 1`]
</div>
<div
class="shareButtonWrapper"
/>
>
<div
class="ShareBoardButton"
>
<button
title="Share board"
type="button"
>
<i
class="CompassIcon icon-globe CompassIcon"
/>
<span>
Share
</span>
</button>
</div>
</div>
</div>
<div
class="ViewHeader"
Expand Down
4 changes: 2 additions & 2 deletions webapp/src/components/centerPanel.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,11 @@ class CenterPanel extends React.Component<Props, State> {
readonly={this.props.readonly}
/>
<div className='shareButtonWrapper'>
{!this.props.readonly && this.props.showShared &&
{!this.props.readonly &&
(
<ShareBoardButton
boardId={this.props.board.id}
enableSharedBoards={this.props.clientConfig?.enablePublicSharedBoards || false}
/>
)
}
Expand All @@ -237,7 +238,6 @@ class CenterPanel extends React.Component<Props, State> {
addCardTemplate={this.addCardTemplate}
editCardTemplate={this.editCardTemplate}
readonly={this.props.readonly}
showShared={this.props.showShared}
/>
</div>

Expand Down
Loading

0 comments on commit 50020ce

Please sign in to comment.