Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autocomplete functionality #50

Merged
merged 1 commit into from
Nov 6, 2020
Merged

Add autocomplete functionality #50

merged 1 commit into from
Nov 6, 2020

Conversation

jrepe
Copy link
Contributor

@jrepe jrepe commented Oct 25, 2020

Summary

This pull request adds slash command autocomplete functionality

Ticket Link

Fixes #39

@mattermod
Copy link

Hello @jrepe,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

hanzei
hanzei approved these changes Oct 26, 2020
View reviewed changes
Copy link
Contributor

@hanzei hanzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hanzei hanzei added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Oct 26, 2020
@hanzei hanzei added this to the v1.2.0 milestone Oct 26, 2020
@mickmister
Copy link
Contributor

LGTM 👍 Thanks @jrepe!

@jrepe
Copy link
Contributor Author

jrepe commented Oct 28, 2020

Great, thanks 🎉

@larkox larkox removed the 2: Dev Review Requires review by a core committer label Oct 28, 2020
@hanzei
Copy link
Contributor

hanzei commented Oct 30, 2020 •
edited
Loading

@DHaussermann I've tested this PR locally and didn't found any issues on this PR. Are you fine with merging this?

One unrelated issue was found: Entering /awssns does crash the plugin. I will submit a separate PR for this.

@hanzei hanzei mentioned this pull request Oct 30, 2020
Closed
4 tasks
DHaussermann
DHaussermann approved these changes Nov 5, 2020
View reviewed changes
Copy link

@DHaussermann DHaussermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hanzei much appreciated. And thanks to @jrepe for this contribution!

LGTM!

@DHaussermann DHaussermann added 4: Reviews Complete All reviewers have approved the pull request and removed 3: QA Review Requires review by a QA tester labels Nov 5, 2020
@hanzei hanzei merged commit a267561 into mattermost-community:master Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHaussermann DHaussermann DHaussermann approved these changes

@hanzei hanzei hanzei approved these changes

@mickmister mickmister mickmister approved these changes

Assignees
No one assigned
Labels
4: Reviews Complete All reviewers have approved the pull request Hacktoberfest hacktoberfest-accepted
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Add slash command autocomplete functionality
6 participants
@jrepe @mattermod @mickmister @hanzei @DHaussermann @larkox