Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scrolling issues on Android P DP2 #1672

Closed
PromoFaux opened this issue May 13, 2018 · 31 comments
Closed

Scrolling issues on Android P DP2 #1672

PromoFaux opened this issue May 13, 2018 · 31 comments

Comments

@PromoFaux
Copy link

Apologies if there is an issue template, however it is not showing on the app I use for GitHub while mobile!

Since updating to the Android Phone DP2 beta, the scrolling in Mattermost 1.8 has been a bit iffy. Not seeing this issue in any other apps.

It seems to work fine if I hold and scroll, however if I try to "fling" scroll, it behaves weirdly. Almost as though it is going the opposite direction to the direction I want it. I will try and attach a video of said behaviours when I'm no longer mobile.

@amyblais
Copy link
Member

Thank you for reporting this @PromoFaux!

I am not aware of an open ticket for this, so I'll help troubleshoot this.

A screenshot / video as a start will be helpful (as you mentioned).

@PromoFaux
Copy link
Author

Hi @amyblais Just shared a video with Elias over on your mm server. (Took it down from here because I realised it had identifying info of our server on it!)

Can share with you over there too, if you like?

@amyblais
Copy link
Member

@PromoFaux Did Elias provide feedback on the video and has there been any progress in troubleshooting the issue outside this Github ticket?

@PromoFaux
Copy link
Author

Last we left it, I was going to try and set up a dev environment and poke about to see if I could spot anything but real life has gotten rather in the way of that so far...

He reckons it's something to do with react-native

@amyblais
Copy link
Member

@PromoFaux Thanks for the update and no worries! Keep me updated on when you are ready to set up a dev environment or if you need any help with that.

@amyblais
Copy link
Member

amyblais commented Jun 1, 2018

Hi @PromoFaux, we haven't received an update so we'll assume that the problem is fixed or is no longer valid.

If the issue persists, reopen this issue with the relevant information and we'd be glad to help you where we can.

@amyblais amyblais closed this as completed Jun 1, 2018
@PromoFaux
Copy link
Author

Sorry Amy, been snowed under with "real life"! Issue still occurring, but I've not looked into why yet. Clearly nobody else has seen it happening! :)

@jfchevrette
Copy link

I have the same issue on Android P DP3.

@amyblais amyblais reopened this Jun 14, 2018
@fedme
Copy link

fedme commented Jun 15, 2018

Same issue here on Android P Developer Preview 2.
Scrolling up a channel only works if done really slow. Normal scroll gesture makes the channel scroll up a bit and then bounce back down.

@amyblais
Copy link
Member

Hey all!

Thanks for reaching out. To give you the best help we can, could you review this web page and send us the relevant logs, config files, etc. so we can diagnose this issue?

We are also releasing a new Mobile App version today (v1.9) and a new server version (v5.0), and if you want to you can try upgrading when these are available to see if you experience any improvements.

Looking forward to helping you!

@PromoFaux
Copy link
Author

Is the v1.9 being released the same as the beta version 1.9 that was released on May 31st? If so, I switched to the beta version a while back to see if it had been fixed and still seeing the same issue :)

Are you experiencing the issues with the Mattermost Mobile App, if so what version and OS?

App version 1.8 (and beta version 1.9) on an original Pixel XL running Android P DP3.

Not sure how to get logs/config files needed for this, any guidance would be appreciated!

@amyblais
Copy link
Member

v1.9 final is not the same as the beta version (it includes a lot more bug fixes and improvements) - the final version will be available in a few days. I'm asking my colleagues if they can repro / if 1.9 final includes fixes related to this (I don't have Android so not able to test myself).

@PromoFaux
Copy link
Author

Just as an update of some further experiments.

Mattermost Mobile v1.9 (build 110) downloaded from github release page - Same issue.
Switching servers between ours and pre-release.mattermost.com - Same issue.
Mattermost 1.9 on Android O - No issue.

It's likely the issue lies in Android P or React, but not sure which.

@amyblais
Copy link
Member

An engineer mentioned just now that there is probably not much we can do from our end for this problem as this seems to be an issue specifically on that platform on RN - perhaps would it help to start with checking with RN if this a known issue on their side or if they are working on a fix?

@jfchevrette
Copy link

This seem to be the same bug: facebook/react-native#19434

I ran the reproducer using Expo on my device running DP4 and the scrolling behaviour is the same.

@PromoFaux
Copy link
Author

@amyblais Might be some movement on an alternative according to this comment

@APengue1
Copy link

APengue1 commented Aug 7, 2018

I have found a workaround to this issue until it can get fixed.

Phone: Pixel XL
Build: 9.0.0 (PPR1.180610.009, Aug 2018)
Mattermost Version: 1.10.0

Scroll with two fingers

@H3npi
Copy link

H3npi commented Aug 27, 2018

Got the same issue on a Pixel 2 XL

App Version: 1.11.0 (Build 133)
Server Version: 5.2.0 (Build 5.2.1)
Database: mysql
Android Version: 9
Build number: PPR1.180610.009

@micolous
Copy link

micolous commented Sep 8, 2018

@amyblais FYI, there's a "simple" workaround mentioned upstream: facebook/react-native#19434 (comment)

@amyblais
Copy link
Member

Hi all, letting you know that our developers are working on a fix / workaround for this, but it's still a work in progress and it will be part of a larger feature in a future release.

@philiplb
Copy link

Glad there is already an issue about this. I experience the same on an Essential Phone with Android Phone, App Version 1.12.0.

@amyblais
Copy link
Member

amyblais commented Oct 1, 2018

Hi all, we've submitted a fix for this issue but we don't have Android P to test the fix internally.

Would anyone here be able to help test the fix? You'd need to sign up for beta testing and then download the latest app version from Google Playstore.

PR: #2161
Jira ticket: https://mattermost.atlassian.net/browse/MM-12273

@philiplb
Copy link

philiplb commented Oct 1, 2018

Hi, just tried it on my Essential Phone with P.
Scrolling works just fine now, bit when I got the pagination at the top, it doesn't load more. Just an endless loading indicator.

@cbenhagen
Copy link

cbenhagen commented Oct 1, 2018 via email

@compilenix
Copy link

I can confirm that this works on the Google Pixel 2 XL with Android P (patch level September 5, 2018)

But i'm unable to load older messages, the loading never completes. This works using the current stable app version.

@amyblais
Copy link
Member

amyblais commented Oct 1, 2018

Hi @philiplb @compilenix For the "endless loading indicator" issue, are there any error messages you're seeing? We're not able to reproduce it internally so any additional information will be helpful.

@compilenix
Copy link

No error, just the loading indicator. I noticed that this does not occur every time.
Sometimes i need to switch between chennels a couple of times and scroll up on each one. At some point no messages get loaded anymore, restarting the app solves the problem until it hangs again.

The first couple of messages, after switching to a channel, does get loaded every time. This problem occures only when older messages get loaded while scrolling.

@koxen
Copy link

koxen commented Oct 1, 2018

confirmed fix on xiaomi with android 9 👍 no problems with infiniscroll either

@PromoFaux
Copy link
Author

Oh wow. I had no idea how much I missed normal scrolling! Thanks @amyblais and team! 👍

@amyblais
Copy link
Member

amyblais commented Oct 2, 2018

It looks like this issue is resolved so I'll close this Github ticket - @compilenix / @philiplb can I ask your help to open a new Github Issue and we can continue to troubleshoot the new issue on the loading indicator there?

@amyblais amyblais closed this as completed Oct 2, 2018
@philiplb
Copy link

philiplb commented Oct 2, 2018

@amyblais Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests