Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dismissing notifications from the RHS view #620

Open
mickmister opened this issue Dec 1, 2022 · 1 comment
Open

Support dismissing notifications from the RHS view #620

mickmister opened this issue Dec 1, 2022 · 1 comment
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Tech/TypeScript Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers

Comments

@mickmister
Copy link
Member

The plugin supports using the RHS to browse unread GitHub notifications, as seen in the screenshot below. When the user navigates to the URL in the notification, GitHub marks the notification as read.

I'm proposing we have a button next to this link that allows the user to dismiss the notification without navigating to the URL. I'm not sure if GitHub's API supports this, but I believe we would just need to send an API request to dismiss that specific notification, and then refresh the view to see the change completed.
@mickmister mickmister added Help Wanted Community help wanted Up For Grabs Ready for help from the community. Removed when someone volunteers Hacktoberfest Tech/Go Good First Issue Suitable for first-time contributors Tech/ReactJS Difficulty/1:Easy Easy ticket Type/Enhancement New feature or improvement of existing feature Tech/TypeScript labels Dec 1, 2022
@mickmister
Copy link
Member Author

It would be great to be able to unsubscribe from the resource associated with the notification as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Difficulty/1:Easy Easy ticket Good First Issue Suitable for first-time contributors Hacktoberfest Help Wanted Community help wanted Tech/Go Tech/ReactJS Tech/TypeScript Type/Enhancement New feature or improvement of existing feature Up For Grabs Ready for help from the community. Removed when someone volunteers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mickmister