-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GHG-654] Added mentions on sidebar buttons / rhs bar #775
base: master
Are you sure you want to change the base?
[GHG-654] Added mentions on sidebar buttons / rhs bar #775
Conversation
…gin-github into cyrusjc/adding-mentions-to-sidebar
style={button} | ||
> | ||
<i className='fa fa-comment-o'/> | ||
{' ' + mentions.length} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaning towards not showing the number of mentions.
There are users who are keen on keeping their inboxes empty. Given that they have no control over this number and can't reduce it, I wonder if we should omit the number. The button would still allow the user to check in on their conversation but would no longer nag them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a good point. I think it makes sense to remove the number. Would we then want to change the ordering of the mentions icon? I was thinking since it would be just an icon we can move it next to the refresh button
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hanzei Is it possible to "remove" mentions? Maybe unsubscribing to the issue/PR does this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cyrusjc Do you know?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't sorry.
Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>
consistency renaming Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>
consistency renaming Co-authored-by: Ayush Thakur <100013900+ayusht2810@users.noreply.github.com>
@cyrusjc There are some merge conflicts to resolve due to a recent typescript PR merge. Can you please take a look at them? Thanks for your work on this!! 😄 |
…gin-github into cyrusjc/adding-mentions-to-sidebar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, nice work @cyrusjc 👍 Just one comment for discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This PR has been automatically labelled "stale" because it hasn't had recent activity. |
Closes #654
Summary:
Added mention icon and associated information in the RHS bar for the mentions in PRs as suggested in the issue.
Changes looks like:
![image](https://private-user-images.githubusercontent.com/32754336/327621238-11806cfc-cd5e-4705-88cf-44c4b1a8141b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3NzE0ODEsIm5iZiI6MTcyNDc3MTE4MSwicGF0aCI6Ii8zMjc1NDMzNi8zMjc2MjEyMzgtMTE4MDZjZmMtY2Q1ZS00NzA1LTg4Y2YtNDRjNGIxYTgxNDFiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI3VDE1MDYyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWMyMzgzMzNlMzJkYmY4NmUzNjg2ZTQ0YTA0YjdlYTlmNGMwODllZmZmZjJkYWZiMmVjMjdkMzg4MGMyOWVjNzAmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lnV2YivhrUntcxnyDV1ILD1LtzKMZf3pRMrFmkPFlJY)
![image](https://private-user-images.githubusercontent.com/32754336/327621267-98a01086-8da1-4719-99bc-d7fa2f18747d.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3NzE0ODEsIm5iZiI6MTcyNDc3MTE4MSwicGF0aCI6Ii8zMjc1NDMzNi8zMjc2MjEyNjctOThhMDEwODYtOGRhMS00NzE5LTk5YmMtZDdmYTJmMTg3NDdkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI3VDE1MDYyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWEwMTNkNTRiOTI4MjU3M2I2ODQ0OTAyOWY4ZTQwMTAzYTEyOTM3NjY5MTNkZjk2MzFmMDM2NzdmOWQ1YmE2N2EmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.S0RCJY-a2-4gJV-UVGKPPqkdX3l5oiuyh4hAfSgNtSI)
![image](https://private-user-images.githubusercontent.com/32754336/327621292-0dd346fc-dc1c-407a-870a-e07e7273c769.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3NzE0ODEsIm5iZiI6MTcyNDc3MTE4MSwicGF0aCI6Ii8zMjc1NDMzNi8zMjc2MjEyOTItMGRkMzQ2ZmMtZGMxYy00MDdhLTg3MGEtZTA3ZTcyNzNjNzY5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI3VDE1MDYyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTRlMGFkNjEyZDg2NjNhZjE5MmY2ZGZiOWRjYjcyYmEyMGYxMTFlZTliMGE0ZGVmNTY1NGEzNWMxMmE4ZjIyNGMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.HlfMKpzvLvP5kw-D5XVcly1PpyOus-4bTk6uy2ZNc0M)