Support excluding specific comment authors for issue comment subscriptions

[mickmister]

Comments from the codecov bot can be a bit spammy in channels subscribing to issue/PR comments. For my use case of the GitHub issue comments subscription, I would like to exclude the codecov bot from creating issue comments in the issue comment subscription.

The task here is to implement a --exclude-users flag that can take a comma-separated list of GitHub usernames to exclude from the subscription posts. This is currently implemented for DM notifications through the mute command, though is not accessible in the subscriptions feature

mattermost-plugin-github/server/plugin/command.go

Line 216 in 2608197

func (p *Plugin) handleMuteCommand(_ *plugin.Context, args *model.CommandArgs, parameters []string, userInfo *GitHubUserInfo) string {

[hanzei]

FYI: There is already a per-user setting in the form of /github mute. It seems useful to me to have both (a per-subscription and a per-user mute) 👍

[mickmister]

@hanzei Funny enough, I had that in the issue description but removed it for some reason

Are you suggesting we call the flag mute when creating/editing the subscription?

[mickmister]

@hanzei I'd like to move this ticket to the monorepo to increase visibility. Do you have any thoughts on my question above?

[hanzei]

My concern is more about whether this setting should be per-user, per-subscription or global. There is already a per-user one. What value does a per-subscription setting add?

[mickmister]

@hanzei The per-user one is for DM notifications. How are you proposing this feature should work? I guess I'm simply not understanding what the exact suggestion is

[mickmister]

@hanzei Do you think this would work well? Or how do you see this working?

/github subscriptions add mattermost/mattermost-plugin-github --exclude-users codecov,mattermod