-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup / removal of inactive users #749
Comments
@mickmister Regarding the approach for the above issue, we can implement the UserHasBeenDeactivated Hook, and whenever a user is deactivated, we can check for the subscriptions linked to the user, if any and delete the subscription. What are your thoughts on this approach, or do you have any other solutions for the approach? |
@ayusht2810 Yeah that sounds great 👍 @nilesingalls Are you wanting to also affect existing deactivated users? That would likely require SQL that we may be able to provide for this |
@mickmister Regarding the above issue, I misunderstood it and posted the wrong approach to it. Sorry for that.
This function is invoked from the /connected API, which is called at various places from the client, due to which we are getting the above issue.Isn't deactivating the user from Mattermost server (as the user is also inactive from GitHub) a way to resolve or should we check if the user exist on GitHub and perform further actions? What are your thoughts on this? Let me know if I am missing something here. |
@ayusht2810 Yeah it doesn't make much sense that these queries would be getting executed if the user is deactivated, and thus not logged into Mattermost. @nilesingalls Are you certain these particular errors are occurring for users that are deactivated from Mattermost? |
These are users who are active in our Mattermost instance but no longer have a github account associated to our github organization. Perhaps our use case is unique in that regard, but we split off a group of users into a separate company. |
@nilesingalls Thanks that makes sense. Are you able to have them each run |
As a Mattermost administrator, what is the best approach to remove subscriptions for inactive users?
We have a few former users showing up in mattermost logs that I'd like to address.
The text was updated successfully, but these errors were encountered: