Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider implementing subscriptions feature as a form/modal #780

Open
mickmister opened this issue May 10, 2024 · 1 comment
Open

Consider implementing subscriptions feature as a form/modal #780

mickmister opened this issue May 10, 2024 · 1 comment
Labels
1: UX Review Requires review by a UX Designer

Comments

@mickmister
Copy link
Member

Currently the subscriptions feature is all in the slash command /github subscriptions add, loaded with some unclear options through slash command flags, in particular the flag named features.

For example:

/github subscriptions add mattermost/mattermost-plugin-github --features pulls,issues,label:"Help Wanted"

image

Description of the feature from the command's help text:

  • /github subscriptions add owner[/repo] [flags] - Subscribe the current channel to receive notifications about opened pull requests and issues for an organization or repository
    • flags currently supported:
      • --features - a comma-delimited list of one or more of the following:
        • issues - includes new and closed issues
        • pulls - includes new and closed pull requests
        • pulls_merged - includes merged pull requests only
        • pulls_created - includes new pull requests only
        • pushes - includes pushes
        • creates - includes branch and tag creations
        • deletes - includes branch and tag deletions
        • issue_comments - includes new issue comments
        • issue_creations - includes new issues only
        • pull_reviews - includes pull request reviews
        • label:<labelname> - limit pull request and issue events to only this label. Must include pulls or issues in feature list when using a label.
        • Defaults to pulls,issues,creates,deletes
      • --exclude-org-member - events triggered by organization members will not be delivered (the GitHub organization config should be set, otherwise this flag has not effect)
      • --render-style - notifications will be delivered in the specified style (for example, the body of a pull request will not be displayed). Supported values are collapsedskip-body or default (same as omitting the flag).
@mickmister
Copy link
Member Author

@asaadmahmood I'm curious if you would be interested in discussing a design for this? I think this feature has slowly grown in scope, to the point where it may make sense to have a dedicated form instead of having the slash command continue to get more loaded with cryptic options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1: UX Review Requires review by a UX Designer
Projects
None yet
Development

No branches or pull requests

1 participant