Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarification on non-browserify integration #128

Open
DullReferenceException opened this issue Apr 3, 2017 · 4 comments
Open

Clarification on non-browserify integration #128

DullReferenceException opened this issue Apr 3, 2017 · 4 comments

Comments

@DullReferenceException
Copy link

Given the description of this project:

Isomorphic WHATWG Fetch API, for Node & Browserify

It seems to imply it is incompatible with webpack. However, looking at the code here, there's this comment:

// Return that as the export for use in Webpack, Browserify etc.

...and I don't see anything that is explicitly Browserify-only here.

Has this been verified to work/not work with webpack bundles? It would be nice to call this out explicitly in the README.

@JohanBjoerklund
Copy link

I haven't tried it with webpack, but it does not work with rollup.

@matthew-andrews
Copy link
Owner

I think webpack should work, that's how we use(d) at the FT.

@matthew-andrews
Copy link
Owner

[didn't mean to close this, sorry!]

@SirGordon
Copy link

SirGordon commented May 8, 2017

I'm using webpack and it doesnt work on old browsers that don't have fetch variable.
Is there any workaround / fix / alternative?
(or maybe I'm doing something wrong?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants