{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":120448048,"defaultBranch":"master","name":"rust","ownerLogin":"matthiaskrgr","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2018-02-06T11:50:38.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/476013?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1726771026.0","currentOid":""},"activityList":{"items":[{"before":"9f0d32c638f654dfe312162002c9e72ba0be3486","after":"f715815bfbae2541b0178e567716ed812690f4bd","ref":"refs/heads/rollup-0q3qyg9","pushedAt":"2024-09-19T18:37:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130558 - taiki-e:s390x-atomic-128, r=cuviper\n\nSupport 128-bit atomics on s390x\n\nSince LLVM 18 (https://github.com/llvm/llvm-project/commit/c568927f3e2e7d9804ea74ecbf11c16c014ddcbc), 128-bit atomics are fully supported on s390x. And the current minimum external LLVM version is now 18 (https://github.com/rust-lang/rust/pull/130487).\n\ns390x 128-bit atomic instructions (lpq,stpq,cdsg) has been present since [the First Edition of the Principles of Operation](https://publibfp.dhe.ibm.com/epubs/pdf/dz9zr000.pdf). (LLVM's minimal supported architecture level [is z10 (the Eighth Edition of the PoP)](https://github.com/llvm/llvm-project/blob/llvmorg-19.1.0/llvm/lib/Target/SystemZ/SystemZProcessors.td#L16-L17).)\n\ncc https://github.com/rust-lang/rust/issues/99069\n\nr? `@cuviper`","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2536516437\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130558\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130558/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130558\">rust-lang#130558</a> - taiki-e:s390x-atomic-128, r=cuviper"}},{"before":"553c20cc9262ec9ad5c068d12fc21947991bbb4e","after":"9f0d32c638f654dfe312162002c9e72ba0be3486","ref":"refs/heads/rollup-0q3qyg9","pushedAt":"2024-09-19T18:37:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130556 - Urgau:link_cfg_internal, r=jieyouxu\n\nMark the `link_cfg` feature as internal\n\nThis PR marks the `link_cfg` feature as internal because it's a perme-unstable feature, only used by `core`/`std`and `unwind`.","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2536438023\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130556\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130556/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130556\">rust-lang#130556</a> - Urgau:link_cfg_internal, r=jieyouxu"}},{"before":"569153a432775da4be886c0163030234880fc656","after":"553c20cc9262ec9ad5c068d12fc21947991bbb4e","ref":"refs/heads/rollup-0q3qyg9","pushedAt":"2024-09-19T18:37:08.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130554 - ShE3py:unsupported-exitcode, r=Noratrieb\n\n`pal::unsupported::process::ExitCode`: use an `u8` instead of a `bool`\n\n`ExitCode` should “represents the status code the current process can return to its parent under normal termination”, but is currently represented as a `bool` on unsupported platforms, making the `impl From<u8> for ExitCode` lossy.\n\nFixes #130532.\n\nHistory: [IRLO thread](https://internals.rust-lang.org/t/mini-pre-rfc-redesigning-process-exitstatus/5426) (`ExitCode` as a `main` return), #48618 (initial impl), #93445 (`From<u8>` impl).","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2536286237\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130554\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130554/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130554\">rust-lang#130554</a> - ShE3py:unsupported-exitcode, r=Nor…"}},{"before":"767ae2b33d3a84502772b1ad9f80825b4e03ce22","after":"569153a432775da4be886c0163030234880fc656","ref":"refs/heads/rollup-0q3qyg9","pushedAt":"2024-09-19T18:37:07.000Z","pushType":"push","commitsCount":21,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130553 - GnomedDev:remove-clippy-paths, r=compiler-errors\n\n[Clippy] Get rid of most `std` `match_def_path` usage, swap to diagnostic items.\n\nPart of https://github.com/rust-lang/rust-clippy/issues/5393.\n\nThis was going to remove all `std` paths, but `SeekFrom` has issues being cleanly replaced with a diagnostic item as the paths are for variants, which currently cannot be diagnostic items.\n\nThis also, as a last step, categories the paths to help with future path removals.","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2536208669\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130553\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130553/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130553\">rust-lang#130553</a> - GnomedDev:remove-clippy-paths, r=c…"}},{"before":"749f80ab051aa0b3724b464130440b0e70a975ac","after":"767ae2b33d3a84502772b1ad9f80825b4e03ce22","ref":"refs/heads/rollup-0q3qyg9","pushedAt":"2024-09-19T18:37:07.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #128001 - Krappa322:master, r=scottmcm\n\nImprove documentation for <integer>::from_str_radix\n\nTwo improvements to the documentation:\n- Document `-` as a valid character for signed integer destinations\n- Make the documentation even more clear that extra whitespace and non-digit characters is invalid. Many other languages, e.g. c++, are very permissive in string to integer routines and simply try to consume as much as they can, ignoring the rest. This is trying to make the transition for developers who are used to the conversion semantics in these languages a bit easier.","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2420852730\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/128001\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/128001/hovercard\" href=\"https://github.com/rust-lang/rust/pull/128001\">rust-lang#128001</a> - Krappa322:master, r=scottmcm"}},{"before":null,"after":"749f80ab051aa0b3724b464130440b0e70a975ac","ref":"refs/heads/rollup-0q3qyg9","pushedAt":"2024-09-19T18:37:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Auto merge of #130069 - GuillaumeGomez:gen-scraped-buttons, r=notriddle\n\nGenerate scraped examples buttons in JS\n\nFollow-up of https://github.com/rust-lang/rust/pull/129796.\n\nTo reduce the page size when there are scraped examples, we can generate their buttons in JS since they require JS to work in any case. There should be no changes in display or in functionality.\n\nYou can test it [here](https://rustdoc.crud.net/imperio/gen-scraped-buttons/doc/scrape_examples/fn.test.html).\n\ncc `@willcrichton`\nr? `@notriddle`","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2511641366\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130069\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130069/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130069\">rust-lang#130069</a> - GuillaumeGomez:gen-scraped-buttons, …"}},{"before":"48b90aaed38a85afafa45a15198a1472b84acf98","after":"c0951bbce262aab3c0dfdd9f3ebbc0bdf7543173","ref":"refs/heads/rollup-l1hok4x","pushedAt":"2024-09-18T15:49:46.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130510 - samueltardieu:doc-letstmt-assign-desugar, r=compiler-errors\n\ndoc: the source of `LetStmt` can also be `AssignDesugar`\n\nFor example, the two following statements are desugared into a block whose `LetStmt` source is `AssignDesugar`:\n\n```rust\n_ = ignoring_some_result();\n(a, b) = (b, a);\n```","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2533761333\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130510\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130510/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130510\">rust-lang#130510</a> - samueltardieu:doc-letstmt-assign-d…"}},{"before":"00c4be3df812c649798a2f127e2739643ba7e7d8","after":"48b90aaed38a85afafa45a15198a1472b84acf98","ref":"refs/heads/rollup-l1hok4x","pushedAt":"2024-09-18T15:49:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130509 - krasimirgg:llvm-20-2, r=nikic\n\nllvm-wrapper: adapt for LLVM API changes, second try\n\nThis is a re-work of https://github.com/rust-lang/rust/pull/129749 after LLVM brought back the APIs used by rust.\n\nNo functional changes intended.\n\n`@rustbot` label: +llvm-main\nr? `@nikic`\ncc: `@tmandry`","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2533750549\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130509\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130509/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130509\">rust-lang#130509</a> - krasimirgg:llvm-20-2, r=nikic"}},{"before":"3443795606eb78901cba2cf413c211a3dbee8bc1","after":"00c4be3df812c649798a2f127e2739643ba7e7d8","ref":"refs/heads/rollup-l1hok4x","pushedAt":"2024-09-18T15:49:45.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130507 - Urgau:check-cfg-raw-keywords, r=jieyouxu\n\nImprove handling of raw-idents in check-cfg\n\nThis PR improves the handling of raw-idents in the check-cfg diagnostics.\n\nIn particular the list of expected names and the suggestion now correctly take into account the \"keyword-ness\" of the ident, and correctly prefix the ident with `r#` when necessary.\n\n`@rustbot` labels +F-check-cfg","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2533154732\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130507\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130507/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130507\">rust-lang#130507</a> - Urgau:check-cfg-raw-keywords, r=ji…"}},{"before":"21313d7947d435217a916c0d71999a077b90c979","after":"3443795606eb78901cba2cf413c211a3dbee8bc1","ref":"refs/heads/rollup-l1hok4x","pushedAt":"2024-09-18T15:49:44.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130471 - khuey:zlib-musl, r=Kobzol\n\nAdd zlib to musl dist image so rust-lld will support zlib compression for debug info there.\n\nFixes #130063.\n\nr? `@Kobzol`","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531431268\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130471\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130471/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130471\">rust-lang#130471</a> - khuey:zlib-musl, r=Kobzol"}},{"before":"aaed38b2a631dfc593454abf471d75d84033773e","after":"21313d7947d435217a916c0d71999a077b90c979","ref":"refs/heads/rollup-l1hok4x","pushedAt":"2024-09-18T15:49:44.000Z","pushType":"push","commitsCount":12,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130457 - nnethercote:cleanup-codegen-traits, r=bjorn3\n\nCleanup codegen traits\n\nThe traits governing codegen are quite complicated and hard to follow. This PR cleans them up a bit.\n\nr? `@bjorn3`","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2529907538\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130457\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130457/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130457\">rust-lang#130457</a> - nnethercote:cleanup-codegen-traits…"}},{"before":null,"after":"aaed38b2a631dfc593454abf471d75d84033773e","ref":"refs/heads/rollup-l1hok4x","pushedAt":"2024-09-18T15:49:43.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Auto merge of #129491 - StackOverflowExcept1on:master, r=m-ou-se\n\nPass `fmt::Arguments` by reference to `PanicInfo` and `PanicMessage`\n\nResolves #129330\n\nFor some reason after #115974 and #126732 optimizations applied to panic handler became worse and compiler stopped removing panic locations if they are not used in the panic message. This PR fixes that and maybe we can merge it into beta before rust 1.81 is released.\n\nNote: optimization only works with `lto = \"fat\"`.\n\nr? libs-api","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2484042066\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/129491\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/129491/hovercard\" href=\"https://github.com/rust-lang/rust/pull/129491\">rust-lang#129491</a> - StackOverflowExcept1on:master, r=m-o…"}},{"before":"7e67d902134661e48a7237e6479396caba55849f","after":"d20649e79d017249a170ad42a8d514f2498909c5","ref":"refs/heads/rollup-lfx3bb4","pushedAt":"2024-09-18T07:03:54.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130499 - ibraheemdev:libs-review, r=Noratrieb\n\nAdd myself to the libs review rotation","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532718530\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130499\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130499/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130499\">rust-lang#130499</a> - ibraheemdev:libs-review, r=Noratrieb"}},{"before":"b21581d1cb2e4cac86d018a5d1299029317f8ee6","after":"7e67d902134661e48a7237e6479396caba55849f","ref":"refs/heads/rollup-lfx3bb4","pushedAt":"2024-09-18T07:03:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130468 - compiler-errors:bidi, r=Nadrieril\n\nMake sure that def id <=> lang item map is bidirectional\n\nSelf-explanatory from assertion. Just makes sure of an invariant that I forgot to enforce when I added `LanguageItems::from_def_id`.","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531205958\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130468\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130468/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130468\">rust-lang#130468</a> - compiler-errors:bidi, r=Nadrieril"}},{"before":"60c3673456cb5eba4d6ac4ed22be179deebb6dcf","after":"b21581d1cb2e4cac86d018a5d1299029317f8ee6","ref":"refs/heads/rollup-lfx3bb4","pushedAt":"2024-09-18T07:03:53.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130466 - davidtwco:aarch64-transparent-test, r=jieyouxu\n\ntests: add repr/transparent test for aarch64\n\nFixes #74396.\n\nMoves `transparent-struct-ptr.rs` to `transparent-byval-struct-ptr.rs` and then adds a new `transparent-opaque-ptr.rs` for aarch64.","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531122405\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130466\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130466/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130466\">rust-lang#130466</a> - davidtwco:aarch64-transparent-test…"}},{"before":null,"after":"60c3673456cb5eba4d6ac4ed22be179deebb6dcf","ref":"refs/heads/rollup-lfx3bb4","pushedAt":"2024-09-18T07:03:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Auto merge of #130454 - durin42:llvm-20-notrunc, r=workingjubilee\n\ntests: allow trunc/select instructions to be missing\n\nOn LLVM 20, these instructions already get eliminated, which at least partially satisfies a TODO. I'm not talented enough at using FileCheck to try and constrain this further, but if we really want to we could copy an LLVM 20 specific version of this test that would restore it to being CHECK-NEXT: insertvalue ...\n\n`@rustbot` label: +llvm-main\nr? `@DianQK`","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2529735544\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130454\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130454/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130454\">rust-lang#130454</a> - durin42:llvm-20-notrunc, r=workingju…"}},{"before":"862f3e768574e39686b768bf34f11b9e4bfe829e","after":"c52d58dce1044c896153082272522a1d499e95b0","ref":"refs/heads/rollup-tg4d0zi","pushedAt":"2024-09-18T02:42:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130496 - jder:issue-130400, r=compiler-errors\n\nFix circular fn_sig queries to correct number of args for methods\n\nFixes #130400. This was a [debug assert](https://github.com/rust-lang/rust/blob/28e8f01c2a2f33fb4214925a704e3223b372cad5/compiler/rustc_hir_typeck/src/fn_ctxt/checks.rs#L2557) added to some argument error reporting code in #129320 which verified that the number of params (from the HIR) matched the `matched_inputs` which ultimately come from ty::FnSig. In the reduced test case:\n\n```\nfn foo(&mut self) -> _ {\n    foo()\n}\n```\n\nThere is a circular dependency computing the ty::FnSig -- when trying to compute it, we try to figure out the return value, which again depends on this ty::FnSig. In #105162, this was supported by short-circuiting the cycle by synthesizing a FnSig with error types for parameters. The [code in question](https://github.com/rust-lang/rust/pull/105162/files#diff-a65feec6bfffb19fbdc60a80becd1030c82a56c16b177182cd277478fdb04592R44) computes the number of parameters by taking the number of parameters from the hir::FnDecl and adding 1 if there is an implicit self parameter.\n\nI might be missing a subtlety here, but AFAICT the adjustment for implicit self args is unnecessary and results in one too many args. For example, for this non-errorful code:\n\n```\ntrait Foo {\n    fn bar(&self) {}\n}\n```\n\nThe resulting hir::FnDecl and ty::FnSig both have the same number of inputs -- 1. So, this PR removes that adjustment and adds a test for the debug ICE.\n\nr? `@compiler-errors`","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532494159\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130496\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130496/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130496\">rust-lang#130496</a> - jder:issue-130400, r=compiler-errors"}},{"before":"32c4d4112c19be740192206920f13e9476faad16","after":"862f3e768574e39686b768bf34f11b9e4bfe829e","ref":"refs/heads/rollup-tg4d0zi","pushedAt":"2024-09-18T02:42:32.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130491 - matthiaskrgr:sehsarc, r=compiler-errors\n\nmore crash tests\n\nr? `@compiler-errors`","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532266123\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130491\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130491/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130491\">rust-lang#130491</a> - matthiaskrgr:sehsarc, r=compiler-e…"}},{"before":"09b255d3d4fdfce05e5878f1e919d5ca84bc9962","after":"32c4d4112c19be740192206920f13e9476faad16","ref":"refs/heads/rollup-tg4d0zi","pushedAt":"2024-09-18T02:42:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130489 - compiler-errors:raw-lt-lint, r=jieyouxu\n\nEnsure that `keyword_ident` lint doesn't trigger on `'r#kw` lifetime\n\nFixes #130486","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532118555\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130489\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130489/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130489\">rust-lang#130489</a> - compiler-errors:raw-lt-lint, r=jie…"}},{"before":"f7b4c72c8ffb320616bda27f70bb8e0a341673fb","after":"09b255d3d4fdfce05e5878f1e919d5ca84bc9962","ref":"refs/heads/rollup-tg4d0zi","pushedAt":"2024-09-18T02:42:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130116 - veera-sivarajan:freeze-suggestions, r=chenyukang\n\nImplement a Method to Seal `DiagInner`'s Suggestions\n\nThis PR adds a method on `DiagInner` called `.seal_suggestions()` to prevent new suggestions from being added while preserving existing suggestions.\n\nThis is useful because currently there is no way to prevent new suggestions from being added to a diagnostic. `.disable_suggestions()` is the closest but it gets rid of all suggestions before and after the call.\n\nTherefore, `.seal_suggestions()` can be used when, for example, misspelled keyword is detected and reported. In such cases, we may want to prevent other suggestions from being added to the diagnostic, as they would likely be meaningless once the misspelled keyword is identified. For context: https://github.com/rust-lang/rust/pull/129899#discussion_r1741307132\n\nTo store an additional state, the type of the `suggestions` field in `DiagInner` was changed into a three variant enum. While this change affects files across different crates, care was taken to preserve the existing code's semantics. This is validated by the fact that all UI tests pass without any modifications.\n\nr? chenyukang","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2512552860\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130116\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130116/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130116\">rust-lang#130116</a> - veera-sivarajan:freeze-suggestions…"}},{"before":null,"after":"f7b4c72c8ffb320616bda27f70bb8e0a341673fb","ref":"refs/heads/rollup-tg4d0zi","pushedAt":"2024-09-18T02:42:30.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Auto merge of #130492 - matthiaskrgr:rollup-9pxkd8i, r=matthiaskrgr\n\nRollup of 2 pull requests\n\nSuccessful merges:\n\n - #130481 (Remove uneeded PartialOrd bound in cmp::Ord::clamp)\n - #130482 (Remove redundant test typeid equality by subtyping)\n\nr? `@ghost`\n`@rustbot` modify labels: rollup","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2532267108\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130492\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130492/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130492\">rust-lang#130492</a> - matthiaskrgr:rollup-9pxkd8i, r=matth…"}},{"before":"0a35418d345ea20534b4ad1e6208bc1018cc0750","after":"7e8eb7aa93b7c39fc8bf4587ef5bfdd6fd251ac2","ref":"refs/heads/rollup-9pxkd8i","pushedAt":"2024-09-17T22:12:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130482 - spastorino:remove-known-bug-97156, r=jackh726\n\nRemove redundant test typeid equality by subtyping\n\nThis known-bug label was a left over on #118247\n\nr? `@jackh726`\n\nThis doesn't address #110395, I didn't investigate about it yet.","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531797078\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130482\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130482/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130482\">rust-lang#130482</a> - spastorino:remove-known-bug-97156,…"}},{"before":"28e8f01c2a2f33fb4214925a704e3223b372cad5","after":"0a35418d345ea20534b4ad1e6208bc1018cc0750","ref":"refs/heads/rollup-9pxkd8i","pushedAt":"2024-09-17T22:12:19.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130481 - krtab:clamp_partial_ord, r=cuviper\n\nRemove uneeded PartialOrd bound in cmp::Ord::clamp\n\nThere is a `Self: PartialOrd` bound in `Ord::clamp`, but it is already required by the trait itself. Likely a left-over from the const trait deletion in 76dbe2910465072f85e74d6f7115ec9e6803e8bf.\n\nReported-by: `@noeensarguet`","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531785041\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130481\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130481/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130481\">rust-lang#130481</a> - krtab:clamp_partial_ord, r=cuviper"}},{"before":null,"after":"28e8f01c2a2f33fb4214925a704e3223b372cad5","ref":"refs/heads/rollup-9pxkd8i","pushedAt":"2024-09-17T22:12:18.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Auto merge of #130483 - matthiaskrgr:rollup-q1r0g0y, r=matthiaskrgr\n\nRollup of 5 pull requests\n\nSuccessful merges:\n\n - #129477 (Fix fluent diagnostics)\n - #129674 (Add new_cyclic_in for Rc and Arc)\n - #130452 (Update Trusty target maintainers)\n - #130467 (Miri subtree update)\n - #130477 (Revert #129749 to fix segfault in LLVM)\n\nr? `@ghost`\n`@rustbot` modify labels: rollup","shortMessageHtmlLink":"Auto merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531849306\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130483\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130483/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130483\">rust-lang#130483</a> - matthiaskrgr:rollup-q1r0g0y, r=matth…"}},{"before":null,"after":"12814c8aa57a496975923711503a5408ee98022f","ref":"refs/heads/sehsarc","pushedAt":"2024-09-17T22:10:42.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"more crash tests","shortMessageHtmlLink":"more crash tests"}},{"before":"90873122a78ca477c9a78de3dc6b67b94ea9addf","after":"f8090dda64203c24713ff66849b49a9d92557ee6","ref":"refs/heads/rollup-q1r0g0y","pushedAt":"2024-09-17T18:45:51.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130477 - tmandry:revert-llvm-20-lto, r=tmandry\n\nRevert #129749 to fix segfault in LLVM\n\nThis reverts commit 8c7a7e346be4cdf13e77ab4acbfb5ade819a4e60, reversing changes made to a00bd75b6c5c96d0a35afa2dc07ce3155112d278.\n\nReported in https://github.com/rust-lang/rust/pull/129749#issuecomment-2354417960. `@nikic's` theory is that the LLVM API changed in a way that makes it impossible to use concurrently from multiple threads (https://github.com/llvm/llvm-project/pull/106427#issuecomment-2354783802). I pinged `@krasimirgg` who was fine with reverting.\n\nr? `@rust-lang/wg-llvm`","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531669260\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130477\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130477/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130477\">rust-lang#130477</a> - tmandry:revert-llvm-20-lto, r=tmandry"}},{"before":"084e93a1cfb4ba9ba08e836bc618562ee37fa72e","after":"90873122a78ca477c9a78de3dc6b67b94ea9addf","ref":"refs/heads/rollup-q1r0g0y","pushedAt":"2024-09-17T18:45:51.000Z","pushType":"push","commitsCount":63,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130467 - RalfJung:miri-sync, r=RalfJung\n\nMiri subtree update\n\nr? `@ghost`","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2531152899\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130467\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130467/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130467\">rust-lang#130467</a> - RalfJung:miri-sync, r=RalfJung"}},{"before":"f6fd305282c88b144933fe7482740880ecfb2ff4","after":"084e93a1cfb4ba9ba08e836bc618562ee37fa72e","ref":"refs/heads/rollup-q1r0g0y","pushedAt":"2024-09-17T18:45:50.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #130452 - randomPoison:trusty-update-maintainers, r=ehuss\n\nUpdate Trusty target maintainers\n\nRemove Stephen Crane from the list of Trusty target maintainers and add Andrei Homescu (`@ahomescu)` and Chris Wailes.","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2529666590\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/130452\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/130452/hovercard\" href=\"https://github.com/rust-lang/rust/pull/130452\">rust-lang#130452</a> - randomPoison:trusty-update-maintai…"}},{"before":"8b36ecba97051d508fcdcfe33a86db35ed8713b9","after":"f6fd305282c88b144933fe7482740880ecfb2ff4","ref":"refs/heads/rollup-q1r0g0y","pushedAt":"2024-09-17T18:45:50.000Z","pushType":"push","commitsCount":9,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #129674 - matthewpipie:rc-arc-new-cyclic-in, r=dtolnay\n\nAdd new_cyclic_in for Rc and Arc\n\nCurrently, new_cyclic_in does not exist for Rc and Arc. This is an oversight according to https://github.com/rust-lang/wg-allocators/issues/132.\n\nThis PR adds new_cyclic_in for Rc and Arc. The implementation is almost the exact same as new_cyclic with some small differences to make it allocator-specific. new_cyclic's implementation has been replaced with a call to `new_cyclic_in(data_fn, Global)`.\n\nRemaining questions:\n* ~~Is requiring Allocator to be Clone OK? According to https://github.com/rust-lang/wg-allocators/issues/88, Allocators should be cheap to clone. I'm just hesitant to add unnecessary constraints, though I don't see an obvious workaround for this function since many called functions in new_cyclic_in expect an owned Allocator. I see Allocator.by_ref() as an option, but that doesn't work on when creating Weak { ptr: init_ptr, alloc: alloc.clone() }, because the type of Weak then becomes Weak<T, &A> which is incompatible.~~ Fixed, thank you `@zakarumych!` This PR no longer requires the allocator to be Clone.\n* Currently, new_cyclic_in's documentation is almost entirely copy-pasted from new_cyclic, with minor tweaks to make it more accurate (e.g. Rc<T> -> Rc<T, A>). The example section is removed to mitigate redundancy and instead redirects to cyclic_in. Is this appropriate?\n* ~~The comments in new_cyclic_in (and much of the implementation) are also copy-pasted from new_cyclic. Would it be better to make a helper method new_cyclic_in_internal that both functions call, with either Global or the custom allocator? I'm not sure if that's even possible, since the internal method would have to return Arc<T, Global> and I don't know if it's possible to \"downcast\" that to an Arc<T>. Maybe transmute would work here?~~ Done, thanks `@zakarumych`\n* Arc::new_cyclic is #[inline], but Rc::new_cyclic is not. Which is preferred?\n* nit: does it matter where in the impl block new_cyclic_in is defined?","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2490657210\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/129674\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/129674/hovercard\" href=\"https://github.com/rust-lang/rust/pull/129674\">rust-lang#129674</a> - matthewpipie:rc-arc-new-cyclic-in,…"}},{"before":"e9e13a68d7271baac458addc056ffff6ddbbe57c","after":"8b36ecba97051d508fcdcfe33a86db35ed8713b9","ref":"refs/heads/rollup-q1r0g0y","pushedAt":"2024-09-17T18:45:49.000Z","pushType":"push","commitsCount":3,"pusher":{"login":"matthiaskrgr","name":"Matthias Krüger","path":"/matthiaskrgr","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/476013?s=80&v=4"},"commit":{"message":"Rollup merge of #129477 - Xiretza:fix-fluent-diagnostics, r=compiler-errors\n\nFix fluent diagnostics\n\nThis line number calculation was both wrong and unnecessary.","shortMessageHtmlLink":"Rollup merge of <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2483638989\" data-permission-text=\"Title is private\" data-url=\"https://github.com/rust-lang/rust/issues/129477\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/rust-lang/rust/pull/129477/hovercard\" href=\"https://github.com/rust-lang/rust/pull/129477\">rust-lang#129477</a> - Xiretza:fix-fluent-diagnostics, r=…"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEuzSLZwA","startCursor":null,"endCursor":null}},"title":"Activity · matthiaskrgr/rust"}