fix(recursOn): allow recursOn to be an empty string

Closes #300
mattlewis92 · Mar 8, 2016 · 4bbde4e · 4bbde4e
1 parent 45f016a
commit 4bbde4e
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/services/calendarHelper.js b/src/services/calendarHelper.js
@@ -30,7 +30,7 @@ angular
       var eventEnd = moment(eventPeriod.end);
       var periodStart = moment(containerPeriodStart);
 
-      if (angular.isDefined(recursOn)) {
+      if (recursOn) {
 
         switch (recursOn) {
           case 'year':

diff --git a/test/unit/services/calendarHelper.spec.js b/test/unit/services/calendarHelper.spec.js
@@ -135,6 +135,18 @@ describe('calendarHelper', function() {
 
     });
 
+    it('should not throw an error when recursOn is an empty string', function() {
+
+      expect(function() {
+        calendarHelper.eventIsInPeriod({
+          startsAt: new Date(),
+          endsAt: new Date(),
+          recursOn: ''
+        }, periodStart, periodEnd);
+      }).not.to.throw();
+
+    });
+
     it('should use the event start time as the end time when no end time is passed', function() {
 
       var isInPeriod = calendarHelper.eventIsInPeriod({