fix: allow translate3d transforms on getElementRect() #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattlewis92
requested changes
Oct 21, 2019
There was a problem hiding this comment.
Hey, thanks for this! It looks like it broke one of the tests though, can you look into that? Could you also add a test case for this issue as well? You should be able to adapt this one: https://github.com/mattlewis92/angular-resizable-element/blob/master/test/resizable.spec.ts#L1422-L1445
Repository owner
deleted a comment from
AliSawari
Dec 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As an example, angular meterial cdkDrag uses translate3d transform to move objects.
Changed the way to extract translateX & translateY to be able to work with 'translate' and 'translate3d' transforms.
original regex from https://stackoverflow.com/a/31658290/4478897