Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to Angular 11 #125

Closed
wants to merge 1 commit into from
Closed

chore: upgrade to Angular 11 #125

wants to merge 1 commit into from

Conversation

arturovt
Copy link
Collaborator

Hey! Just upgraded to the latest version to ensure that nothing is broken. Also there is no node-sass right now, so I was able to install packages successfully 😄 Ping me if some package needs to be updated in addition.

@mattlewis92
Copy link
Owner

Thanks for this! I have been meaning to just migrate this repo over to the CLI (this lib was written before the cli had proper library support) and was gonna upgrade angular then. I just haven't had the time to do it yet 😅 I don't think we can release this in a minor version as it will probably break support for older angular versions so gonna leave it for now. My workaround for the node-sass issue has been to do nvm use 10 on this repo 😄

@mikeomeara1
Copy link

Hey gents - any chance this can get merged? Has us stuck on Angular 8 ATM.

mattlewis92 added a commit that referenced this pull request Aug 30, 2021
BREAKING CHANGE: angular 10 or higher is now required to use this package

Closes #125
@mattlewis92
Copy link
Owner

Hey gents - any chance this can get merged? Has us stuck on Angular 8 ATM.

I just shipped 4.0.0 of this lib with the upgraded angular version! (although it should have worked OK before with any version of angular above v6 - I was using v3.x with no problems on the latest angular version)

@mikeomeara1
Copy link

Woot! Looks great @mattlewis92! Thanks for the super-speed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants