fix: copy canvas when using enableGhostResize
#129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one, thanks for this! Would you be able to take a go at adding a test for it as well? I think we can use the code you added to the demo as a test case and then we just need to assert that the ghost element has the canvas text inside it while resizing. Let me know if that makes sense or you need any help! 🙌 |
|
Ok. I added test. I used canvas.toDataURL() to check canvas inner data. |
mattlewis92
changed the title
enableGhostResize
|
Released as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy all content of resized node, includes canvas.
Use implementation deepCloneNode from @angular/cdk 11.0