fix: Add startingRect scroll position to cloned node. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
+ Coverage 95.43% 95.47% +0.03%
==========================================
Files 4 4
Lines 285 287 +2
Branches 42 42
==========================================
+ Hits 272 274 +2
Misses 8 8
Partials 5 5
Continue to review full report at Codecov.
|
|
LGTM, thanks! re the tests, are you on the latest chrome / running |
|
@mattlewis92 No prob! I am on the latest Chrome, but I was just using |
|
Hey @mattlewis92 , any idea if this will be merged or not? |
|
Oops sorry, I am away travelling atm and forgot about this. Will cut a release now 😄 |
|
Released as 1.2.3 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where elements that have been scrolled are losing their scroll position during resize. It takes the scrollTop and scrollLeft values of the original element and applies it to the ghost element.
I was going to write a test for it but I couldn't get Karma to run the already existing tests without detaching from Chrome, running out of memory, etc. Perhaps someone could help me out with that task. :)