Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resizable-directive): browser check for angular universal #83

Merged
merged 4 commits into from
Feb 28, 2019
Merged

fix(resizable-directive): browser check for angular universal #83

merged 4 commits into from
Feb 28, 2019

Conversation

philip-firstorder
Copy link
Contributor

Because it doesn't know what document is
Fixes 'ReferenceError: document is not defined'

Because it doesn't know what document is
Fixes 'ReferenceError: document is not defined'
Copy link
Owner

@mattlewis92 mattlewis92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks like it was working until the previous version, I should probably try and add a universal smoke test to the CI build somewhere to prevent this happening again

src/resizable.directive.ts Outdated Show resolved Hide resolved
src/resizable.directive.ts Outdated Show resolved Hide resolved
src/resizable.directive.ts Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Feb 28, 2019

Codecov Report

Merging #83 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #83      +/-   ##
==========================================
+ Coverage   95.94%   95.97%   +0.02%     
==========================================
  Files           4        4              
  Lines         296      298       +2     
  Branches       29       29              
==========================================
+ Hits          284      286       +2     
  Misses          8        8              
  Partials        4        4
Impacted Files Coverage Δ
src/resizable.directive.ts 95.75% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c2c74c...e17d632. Read the comment docs.

@philip-firstorder
Copy link
Contributor Author

All fixed. If you would be so kind to merge and release, you‘ll get a virtual beer directly from the Oktoberfest brewery next to me.

@mattlewis92 mattlewis92 merged commit 210decc into mattlewis92:master Feb 28, 2019
@mattlewis92
Copy link
Owner

Perfect, thank you! Cutting a new release momentarily 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants