Why use prettier?

[barm]

Hey Matt, love the idea here. I'm considering this for use and one question I had is: why run the async script / source script through prettier? Doesn't seem worth the tradeoff to me of needing a top-level dependency for prettier for code that will really only be read by the browser. Probably is some slight perf penalty too but haven't profiled it to know if it's meanginful. Thanks for in advance for entertaining my question!

[mattlewis92]

Hey! It was mainly just done as a quick fix to make sure the output was readable and formatted correctly, I think it could be swapped out for something simpler like https://github.com/dmnd/dedent or maybe there's even a webpack helper function to do it? Would happily accept a PR to improve this!

[barm]

Cool, I'll take a look and come back with a proposal!

[thomaswelton]

Probably is some slight perf penalty too

Prettier makes up 99.4% of this packages overall size
https://bundlephobia.com/package/webpack-retry-chunk-load-plugin@2.2.0

[hirbod]

@thomaswelton will this also bloat the production code or only in development? Not sure how much overhead this plugin would add right now - I don't want to ship prettier to the final product

[mattlewis92]

@thomaswelton will this also bloat the production code or only in development? Not sure how much overhead this plugin would add right now - I don't want to ship prettier to the final product

The plugin doesn't bundle prettier inside your apps code, it's just installed in your node_modules, the only benefit to swapping it out is to the developer for a slightly faster npm install time of the package, as well as taking up less space on the disk.

[hirbod]

@mattlewis92 thanks for clarification. So a no brainer, since prettier is installed anyway in my project :)

[joeycozza]

@thomaswelton will this also bloat the production code or only in development? Not sure how much overhead this plugin would add right now - I don't want to ship prettier to the final product

The plugin doesn't bundle prettier inside your apps code, it's just installed in your node_modules, the only benefit to swapping it out is to the developer for a slightly faster npm install time of the package, as well as taking up less space on the disk.

Heroku has a slug size limit, and the slug includes node_modules. So relying on prettier does potentially impact more than just slightly faster npm install time and local disk space. Some of the teams I work with are bumping into the slug size limit.