From dfb2be675375a2a93a1d1d55272ef34b78b28b43 Mon Sep 17 00:00:00 2001 From: Matt Jacobs Date: Thu, 30 Jul 2015 16:52:21 -0700 Subject: [PATCH] Cleanup Javadoc for HystrixCommandMetrics --- .../main/java/com/netflix/hystrix/HystrixCommandMetrics.java | 3 +++ .../strategy/metrics/HystrixCommandMetricsSummary.java | 4 ---- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCommandMetrics.java b/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCommandMetrics.java index 5e80d0552..5a9559bd3 100644 --- a/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCommandMetrics.java +++ b/hystrix-core/src/main/java/com/netflix/hystrix/HystrixCommandMetrics.java @@ -414,6 +414,9 @@ public long getRollingMaxConcurrentExecutions() { /** * Retrieve a snapshot of total requests, error count and error percentage. + * + * Marked final so that concrete implementation may vary how to implement {@link #getRollingCount(HystrixRollingNumberEvent)} + * and the health check (used for opening a {@link HystrixCircuitBreaker} is constant * * @return {@link HealthCounts} */ diff --git a/hystrix-core/src/main/java/com/netflix/hystrix/strategy/metrics/HystrixCommandMetricsSummary.java b/hystrix-core/src/main/java/com/netflix/hystrix/strategy/metrics/HystrixCommandMetricsSummary.java index 1d9cc4e8b..e616cc768 100644 --- a/hystrix-core/src/main/java/com/netflix/hystrix/strategy/metrics/HystrixCommandMetricsSummary.java +++ b/hystrix-core/src/main/java/com/netflix/hystrix/strategy/metrics/HystrixCommandMetricsSummary.java @@ -79,10 +79,6 @@ protected void updateRollingMax(HystrixRollingNumberEvent event, long value) { counter.updateRollingMax(event, value); } - public long getRollingMaxConcurrentExecutions() { - return counter.getRollingMaxValue(HystrixRollingNumberEvent.COMMAND_MAX_ACTIVE); - } - /** * Execution time of {@link HystrixCommand#run()}. */