Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lighthouse checks to build for perf testing #318

Closed
mattstratton opened this issue Dec 9, 2020 · 3 comments · Fixed by #321
Closed

Add lighthouse checks to build for perf testing #318

mattstratton opened this issue Dec 9, 2020 · 3 comments · Fixed by #321
Labels
chore Maintenance related

Comments

@mattstratton
Copy link
Owner

Investigate adding this action to the build/PR process: https://github.com/GoogleChrome/lighthouse-ci

@mattstratton mattstratton added the chore Maintenance related label Dec 9, 2020
@mattstratton
Copy link
Owner Author

mattstratton commented Dec 9, 2020

I think this will possibly work if we use this action as well to get the hugo site(s) built?

https://github.com/peaceiris/actions-hugo

GitHub
GitHub Actions for Hugo ⚡️ Setup Hugo quickly and build your site fast. Hugo extended, Hugo Modules, Linux (Ubuntu), macOS, and Windows are supported. - peaceiris/actions-hugo

@mattstratton
Copy link
Owner Author

In #319 I got the initial setup done, but it's not complete. I want to merge that PR, but leave this issue open since there are a few more things to do:

Currently only tests the default configuration. I need to do some more research on GH actions to figure out how to do a better matrix test (similar to what we do with circle; I don't think we have to test every color permutation, but we should check the following:

  • blue-grid
  • blue-row-jumbo-false
  • blue-row-jumbo-true

@mattstratton
Copy link
Owner Author

I got this mostly working. The overall status check will only report on one, so you have to dig into each one to see all the reports for each configuration. But that's probably fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Maintenance related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant