Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DicConfigLoader: better error handling #1

Open
matuszeman opened this issue Aug 4, 2017 · 0 comments
Open

DicConfigLoader: better error handling #1

matuszeman opened this issue Aug 4, 2017 · 0 comments
Assignees

Comments

@matuszeman
Copy link
Owner

Story

As developer, I want to know clearly that I passed invalid object into loadConfig method.

Current behaviour

We get unclear error what might went wrong when non JSON object is passed into loadConfig method:

/src/dic-config-loader.js:45
_.each(config.options, (opts, service) => {
TypeError: Cannot read property 'options' of undefined

Suggested implementation

loadConfig validation should be improved

@matuszeman matuszeman self-assigned this Aug 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant