Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative links in feeds aren't handled correctly #7

Closed
TheFrenchGhosty opened this issue Sep 17, 2019 · 4 comments
Closed

Relative links in feeds aren't handled correctly #7

TheFrenchGhosty opened this issue Sep 17, 2019 · 4 comments
Labels
bug Something isn't working

Comments

@TheFrenchGhosty
Copy link

The bot seems to be broken and is posting broken HTML when Github Wiki updates happen: <p>New post in nitter: Recent Wiki Updates: <a href=\"/zedeus/nitter/wiki\"></a></p> instead of the actual link.

s

(Used for the Nitter room)

@tulir tulir changed the title Github Wiki updates - Links are broken Relative links in feeds aren't handled correctly Sep 17, 2019
@tulir tulir added the bug Something isn't working label Sep 17, 2019
@tulir
Copy link
Member

tulir commented Sep 17, 2019

Looks like there are two problems there. Relative links should now be fixed (the feed parsing library already supported it but I forgot to pass the URL to it), but I can't do much about the lack of a title in the feed itself. You can change the template to something else, e.g. !rss template <id> $link was edited on the Nitter wiki (where <id> can be found with !rss subscriptions).

@tulir tulir closed this as completed in bcbab52 Sep 17, 2019
@TheFrenchGhosty
Copy link
Author

Seems to be working perfectly now, thanks for the fix!

@TheFrenchGhosty
Copy link
Author

After some days it looks like it's still working in another room... but it's still broken in the Nitter's room

@Perflyst
Copy link

It is broken again in #bibliogram:matrix.org

"content": {
    "body": "New post in bibliogram: Recent Wiki Updates: [](/cloudrac3r/bibliogram/wiki/List-of-the-different-Instagram-embeds)",
    "format": "org.matrix.custom.html",
    "formatted_body": "<p>New post in bibliogram: Recent Wiki Updates: <a href=\"/cloudrac3r/bibliogram/wiki/List-of-the-different-Instagram-embeds\"></a></p>\n",
    "msgtype": "m.notice"
  }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants