Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pack/unpack should use getproperty instead of getfield #49

Closed
mauro3 opened this issue Feb 18, 2018 · 1 comment · Fixed by #95
Closed

Pack/unpack should use getproperty instead of getfield #49

mauro3 opened this issue Feb 18, 2018 · 1 comment · Fixed by #95
Labels
help wanted priority Julia-0.7

Comments

@mauro3
Copy link
Owner

mauro3 commented Feb 18, 2018

Also fieldnames should be replaced with propertynames, presumably with private=false, see https://docs.julialang.org/en/latest/base/base/#Base.propertynames.

x-ref: JuliaLang/julia#24960
@mauro3
Copy link
Owner Author

mauro3 commented Aug 2, 2018 •
edited
Loading

I started on this in https://github.com/mauro3/Parameters.jl/tree/m3/properties

If I don't get side-tracked, I plan to finish this at the JuliaCon hackathon.

@mauro3 mauro3 pinned this issue Jan 25, 2019
@tkf tkf mentioned this issue Feb 19, 2019
Merged
@mauro3 mauro3 unpinned this issue Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted priority Julia-0.7
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Use property interface tkf/Parameters.jl
1 participant
@mauro3