Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bridge not invite to archived chats #674

Open
Haui1112 opened this issue Dec 10, 2023 · 5 comments
Open

Make bridge not invite to archived chats #674

Haui1112 opened this issue Dec 10, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@Haui1112
Copy link

Hi folks,

I just installed the whatsapp bridge (after using the discord bridge for longer, works great btw) and got 300+ invites. 10 of those were active whatsapp chats, the rest was archived crap. The bot also added 57 pages of users to my userlist (which were like 20 before) just because I did "login +phonenumber". Now I can't decline the 300 invites at once and get rate limited every 10 declines roughly...

Please change this.

Bug
Bridge copies the entire chat list from whatsapp and recreates all chats and users and sends invites to every single one

Steps to recreate

  1. Install bridge with provided docker compose file https://docs.mau.fi/bridges/general/docker-setup.html?bridge=whatsapp
  2. Configure bridge for homeserver
  3. Restart bridge, then homeserver
  4. Open Chat with bot
  5. type "login {phonenumber}"
  6. get hundreds of invites (depending on the amount of chats you have)

Expected behavior

  • login ->
    • do nothing except establishing the connection
    • ask what should be done
    • sync the active chats, in no case the archived ones without prompt
  • documentation
    • provide clear warning of this happening/ways to alleviate the problem
@Haui1112 Haui1112 added the bug Something isn't working label Dec 10, 2023
@tulir
Copy link
Member

tulir commented Dec 10, 2023

The number of chats to sync initially can be configured: https://github.com/mautrix/whatsapp/blob/master/example-config.yaml#L135-L137. The default is not going to be changed as most people expect all chats to be synced, but an option to not sync archived chats automatically may be reasonable.

Double puppeting is also recommended to auto-accept invites https://docs.mau.fi/bridges/general/double-puppeting.html

@Haui1112
Copy link
Author

The main problem that I'm seeing is that the different behaviors between bridges are inconsistent. I just installed mautrix-signalgo and it doesnt auto sync all chats.

While I thank you for mentioning the initial chat sync number, I would suggest that all bridges behave the same at login: No auto sync without prompt

@tulir
Copy link
Member

tulir commented Dec 10, 2023

The default config in all bridges is to auto sync on login. Signal just doesn't support syncing anything, it would sync everything if it was possible. Discord guilds are often big and not useful, so they're not synced, but discord DMs are synced automatically.

@Haui1112
Copy link
Author

Haui1112 commented Dec 12, 2023

Ok, thanks for elaborating. Though I think there should be a warning that potentially 100s (400 in my case) of rooms and users (600 in my case) can come from one single whatsapp login. I consider this unintended from my personal view. Consider someone running this on a slow computer and 10 friends who all login through the bridges and spam the server with new rooms and users.

Also, why is it a problem to make the bridges sync on prompt instead of login? If I log in, rooms sync with activity, if I want them all synced I can say so.

@niebloomj
Copy link

As a user, I definitely want to sync archived chats automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Development

No branches or pull requests

3 participants