Tidb support #155
Merged
Tidb support #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @morgo , thanks for the PR!! Sorry for the delayed response, I will give it try and if all goes good I will merge it, on what I won't be able to commit is on future releases tests and bug fixes affecting only Tidb because as you may know I already have limited time to just keep up to date on what is supported today. |
|
No problem. Thank you for taking a look! |
|
Just an FYI: I removed a feature that I had added, but we no longer recommend ( |
maxbube
reviewed
Feb 6, 2019
maxbube
reviewed
Feb 6, 2019
maxbube
reviewed
Feb 6, 2019
|
I have addressed the comments in 5e612b0 Thank you for the review! |
|
and update on this PR? |
wimpunk
pushed a commit
to wimpunk/mydumper
that referenced
this pull request
Jan 8, 2020
* Add TiDB Support to mydumper * Added a .gitignore file * Exit if snapshot can not be acquired * Added missing free for query. * Changed tidb-snapshot flag to lower case Makes more sense * Added optimization for _tidb_rowid * Fixed formatting, removed debugging * Revert unnecessary change * Small fixes * Fixed bug in TZ being lost to detected_server * Changed from NOW() to MASTER STATUS for TiDB TSO * Removed _tidb_rowid (no longer recommended) * Reverted formatting change * Addressed PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add version detection for TiDB (detected_server).
Added support for tidb_snapshot option.
Auto-set tidb_snapshot to 1 second ago when TiDB detected.
Added optimization to dump _tidb_row id when it exists.
Tested on TiDB 2.1 + MySQL 5.7.19 (to make sure detected_server matched both correctly).