Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use modern HTTP parser #5

Closed
maxharlow opened this issue Jun 29, 2019 · 1 comment
Closed

Use modern HTTP parser #5

maxharlow opened this issue Jun 29, 2019 · 1 comment

Comments

@maxharlow
Copy link
Owner

Currently uses the legacy Node HTTP parser, seen here: https://github.com/maxharlow/reconcile/blob/master/reconcile#L1.

This is because the modern one produces HPE_INVALID_HEADER_TOKEN errors when it receives headers it doesn't expect.

Would be nice to remove this when it's fixed in Node.
@maxharlow
Copy link
Owner Author

maxharlow commented Jan 13, 2020 •
edited
Loading

https://github.com/nodejs/node/blob/master/doc/api/cli.md#--insecure-http-parser
Or nodejs/node#30570

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@maxharlow