Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Easy Github Pages #176

Closed
omarcostahamido opened this issue Oct 24, 2023 · 0 comments · Fixed by #177
Closed

Easy Github Pages #176

omarcostahamido opened this issue Oct 24, 2023 · 0 comments · Fixed by #177
Labels
bug Something isn't working

Comments

@omarcostahamido
Copy link
Contributor

Describe the bug
Following discussion #144 might not be enough to have github pages running smoothly.

  • If the repo has other branches with deployed actions it will not suggest the jekyll template. So I suggest adding it to the repo ourselves already.
  • once successfully deployed, some pages won't load, like the recent blog entries on the main page, also the image and sound assets won't load. this is due to missing base.url on these pages.
  • additionally I noticed that the _config.yml instructions for github pages are missleading. The baseurl here does nothing on this github pages deployment - it is the one from the workflow file.

I am proposing a pull request in the next couple of minutes to address all these.

@omarcostahamido omarcostahamido added the bug Something isn't working label Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant