-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crackling sound in ESP8266 cores 2.5.1 and higher #2
Comments
Hello Kirill, thank you for reporting your issue. That timer issue I encountered didn't result in crackling sound, but caused the delay function to not wait long enough. I haven't tested with the latest versions for some time now. Can you tell me which versions of the Arduino IDE and of the ESP8266 core you are using? Perhaps I can find some time later this week to look into it. |
@maxint-rd Thanks for advice about portable usage. But now I can't find working combination Arduino IDE / Modules :( |
Hi Kirill, thanks for the swift reply. So first I tried to reproduce your issue. These are the steps I took:
Result: crackling noise! The good news is that I was able to reproduce your issue. Good news because now I can analyse the issue!
So for now I can only recommend you to try the 2.5.0 core. Can you please try to see if that version works for you too? (Along with my delay() workaround). |
Found the problem. Main cause was PROGMEM float alignment issue introduced in core 2.5.1. |
Thanks @maxint-rd ! |
Hi Kirill, thank you for reporting this issue and for your testing. This library got better thanks to your help! |
I just spent 6 hours thinking I had a circuit problem using plain old analogwrite, then updated my projects that use this to test, and behold clicky broken! man what a waste of time. |
Hi @tablatronix , if it's any consolation: I also spent multiple hours on this. I found that it was due to a problem in the newer cores and I submitted an issue to have it fixed in the core. |
I think it is fixed in staging now (platform io was not updating the platform!), I saw the tone no tone additions and that null fix, thanks! I am not sure i know what the ::tone is, new to me. I was checking the commits to figure out what you did there. |
The double colon in the ::tone() call makes sure that it doen't call the tone() method that is defined in the parent class, but rather the tone function defined at the global level, i.e. the one in the Arduino library. The reason I also have an implementation in the MmlMusic library is that if I remember well once (in a time far far away), the tone function wasn't available/working in the ESP core. Another reason was (or might have been, I not quite sure...) that for some environments the MmlMusic library is using the timer interrupt that would be used by the tone function. |
Hi @maxint-rd
Thanks for useful library.
After some years of stable work I updated Arduino IDE and their libraries (and https://github.com/esp8266/Arduino too). Nothing changed in my code but now music not play as expected. It's just creak from speaker.
I see this commit and paste this code into my sketch but nothing changed.
My code example placed here: https://github.com/UksusoFF/wemos-doorbell/blob/master/wemos-doorbell.ino
Can you help me found solution?
The text was updated successfully, but these errors were encountered: