Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async Support? #11

Closed
niemyjski opened this issue Mar 24, 2015 · 5 comments
Closed

Async Support? #11

niemyjski opened this issue Mar 24, 2015 · 5 comments
Labels
enhancement

Comments

@niemyjski
Copy link

It would be nice to be able to create a DatabaseReader async.
@luisrudge
Copy link

👍 to that

@niemyjski
Copy link
Author

👍

@cotzo
Copy link

cotzo commented Apr 6, 2016

+1

@Quppa Quppa mentioned this issue Mar 31, 2018
Closed
@Quppa
Copy link
Contributor

Quppa commented Mar 31, 2018

I added an async CreateReader method with overloads for files and streams to mirror the existing constructors.

Caveats:

  • These methods will always load the data into memory (memory-mapped files won't be used).
  • DatabaseReader in GeoIP2 will need to be updated to optionally use these methods for this to be of any use. I'm happy to do that if/once the above changes are accepted for this project.

@oschwald
Copy link
Member

This was done in #44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Milestone
No milestone
Development

No branches or pull requests
5 participants
@oschwald @luisrudge @niemyjski @Quppa @cotzo