tag should be validated against both minLength and maxLength in tryAdd()

[jrencz]

now maxLength is implemented as attribute in template and min as condition in controller, which is inconsistent (both in code and in tests) and - in the case I run into it - adds complexity to project unit tests of modules which use this function.

It'll also make it easier to validate min and max (to define ng-invalid-* helper class)

[mbenford]

Hi Jarek.

maxLength has always been an attribute applied to the underlying input element. minLength, on the other hand, has to be implemented in Javascript because a "short" tag isn't supposed to be added, and I can't do that in HTML only.

What exactly do you find inconsistent?

[mgol]

@mbenford You could apply the same logic to the minlength attribute as you do form maxlength. The native maxlength has a flaw that you can't even type anything beyond the limit and it's often useful to paste sth a little longer and remove some characters.

[mbenford]

Thanks, @mzgol. Now I get it and it makes sense. Will think more about it.