-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing py.typed file #2
Comments
Closed in #3 |
Thanks for the interest and your contribution. I don't personally use mypy but having a play with your change, it seems to me that some additional changes would be required to fix the outstanding errors that mypy reports:
Can you please confirm and if so one of us can add these changes to the new release branch |
I just opened another issue with some improvements I've been experimenting with.. I did also add a def optimise(
inverse_odds: list[float],
sum_inverse_odds: float,
n: int,
max_iterations: int = 1000,
convergence_threshold: float = 1e-12,
) -> tuple[float, float, float]:
... I just assumed it would take the same args as the python func given how its used. I'd be happy to tidy these things up and add mypy to your testing/ci? |
Hi,
Just started using
shin
- thanks for making the package available!In testing I've noticed that while the source is typed correctly mypy won't recognize it as typed due to missing the
py.typed
marker file.Here is mypy output:
The text was updated successfully, but these errors were encountered: