Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for a correct low limit of the multi-period EF (right part) #47

Open
chilango74 opened this issue Oct 7, 2022 · 0 comments
Open
Labels
bug Something isn't working

Comments

@chilango74
Copy link
Collaborator

Right part of the multi-period Efficient frontier now uses a limit defined as:
“The asset with max CAGR lying to the right of the global max CAGR point (risk should be more than self.max_return['Risk']).”
This definition is realized in _max_cagr_asset_right_to_max_cagr() method.

However, this definition sometimes fails:
image

Correct algorithm should look for points in the outer space (to the right) of line Global Max CAGR – Max Risk Asset. In this set it should look for an asset with highest CAGR. If there are no assets to right of the line the right part of EF should be skipped.

@chilango74 chilango74 added the bug Something isn't working label Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant