Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests are broken since 0.5. #25

Closed
jgravois opened this issue Sep 9, 2016 · 2 comments
Closed

Tests are broken since 0.5. #25

jgravois opened this issue Sep 9, 2016 · 2 comments
Assignees

Comments

@jgravois
Copy link

jgravois commented Sep 9, 2016

ran into the error below when running npm test

> shapefile@0.5.3 test /Users/john6251/github/shapefile
> tape 'test/**/*-test.js'

/Users/john6251/github/shapefile/dbf/index.js:1
(function (exports, require, module, __filename, __dirname) { import slice from "slice-source";
                                                              ^^^^^^
SyntaxError: Unexpected reserved word

tape doesn't appear to be happy being pointed straight at the ES6 source (at least on my box), but since i don't have any trouble running d3 tests locally that follow the same pattern, i'm stumped as to what i could have misconfigured.

@mbostock mbostock changed the title tests failing "SyntaxError: Unexpected reserved word ... import" Tests are broken since 0.5. Sep 9, 2016
@mbostock mbostock self-assigned this Sep 9, 2016
@mbostock
Copy link
Owner

mbostock commented Sep 9, 2016

Yeah, sorry, I haven’t updated the internal dbf-test.js and shp-test.js since 0.5. Those tests need to be rewritten to use the public API; they currently use the private internal API which is no longer available on Node (since they are written in ES6 and transpiled to ES5 using Rollup, and the resulting bundle doesn’t expose the internal methods).

I did just fix a small error in index-test.js and so that works now, though.

@jgravois
Copy link
Author

jgravois commented Sep 9, 2016

no worries. thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants