Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSDOM tests #4

Merged
merged 2 commits into from
Sep 24, 2020
Merged

Fix JSDOM tests #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a91080e
Fix jsdom tests
eps1lon Sep 24, 2020
f44cc53
more concrete explainer
eps1lon Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions packages/material-ui/src/Autocomplete/Autocomplete.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,7 +234,10 @@ describe('<Autocomplete />', () => {
getByRole('textbox').focus();
});
expect(container.textContent).to.equal('onetwothree');
expect(getAllByRole('button', { hidden: false })).to.have.lengthOf(5);
// Depending on the subset of components used in this test run the computed `visibility` changes in JSDOM.
if (!/jsdom/.test(window.navigator.userAgent)) {
expect(getAllByRole('button', { hidden: false })).to.have.lengthOf(5);
}
});

it('show 0 item on close when set 0 to limitTags', () => {
Expand All @@ -257,7 +260,10 @@ describe('<Autocomplete />', () => {
getByRole('textbox').focus();
});
expect(container.textContent).to.equal('onetwothree');
expect(getAllByRole('button', { hidden: false })).to.have.lengthOf(5);
// Depending on the subset of components used in this test run the computed `visibility` changes in JSDOM.
if (!/jsdom/.test(window.navigator.userAgent)) {
expect(getAllByRole('button', { hidden: false })).to.have.lengthOf(5);
}
});
});

Expand Down Expand Up @@ -637,12 +643,9 @@ describe('<Autocomplete />', () => {
expect(listbox).to.equal(null);

const buttons = getAllByRole('button', { hidden: true });
// Depending on the subset of components used in this test run the computed `visibility` changes in JSDOM.
if (!/jsdom/.test(window.navigator.userAgent)) {
expect(buttons[0]).toBeInaccessible();
} else {
// JSDOM thinks the "Clear"-button has `visibility: visible`
// Leaving this to be notified once the JSDOM is fixed.
expect(buttons[0]).not.toBeInaccessible();
}
expect(buttons[1]).toHaveAccessibleName('Open');
expect(buttons[1]).to.have.attribute('title', 'Open');
Expand Down Expand Up @@ -1339,7 +1342,7 @@ describe('<Autocomplete />', () => {
expect(htmlOptions[0].innerHTML).to.equal('one');
});

it('should display a \'no options\' message if no options are available', () => {
it("should display a 'no options' message if no options are available", () => {
const { getByRole } = render(
<Autocomplete
{...defaultProps}
Expand Down